Skip to content

Fix RTK shim recursion for Vitest passthrough#1497

Open
jeffpcbr wants to merge 1 commit intortk-ai:masterfrom
jeffpcbr:codex/vitest-passthrough-rtk-shim
Open

Fix RTK shim recursion for Vitest passthrough#1497
jeffpcbr wants to merge 1 commit intortk-ai:masterfrom
jeffpcbr:codex/vitest-passthrough-rtk-shim

Conversation

@jeffpcbr
Copy link
Copy Markdown

Summary

  • bypass RTK shims for child commands launched through resolved_command
  • pass through help/version-style Vitest and Jest invocations instead of parsing them as test output
  • synthesize Vitest version output through Node when available to avoid recursive shim rewrites

Tests

  • cargo test test_should_passthrough_info_args
  • cargo test test_should_synthesize_vitest_version
  • cargo test test_resolved_command_sets_rtk_disabled

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Orbin Runtime seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pszymkowiak pszymkowiak added bug Something isn't working effort-medium 1-2 jours, quelques fichiers filter-quality Filter produces incorrect/truncated signal labels Apr 24, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

🐛 Type bug-fix
🟡 Risk medium

Summary

Fixes recursive shim invocation when RTK wraps Vitest/Jest by detecting help/version-style arguments and passing them through directly instead of parsing as test output. Sets RTK_DISABLED=1 on child processes spawned via resolved_command to prevent shell-level shim loops, and synthesizes Vitest version output through Node when possible.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Analyzed automatically by wshm · This is an automated analysis, not a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working effort-medium 1-2 jours, quelques fichiers filter-quality Filter produces incorrect/truncated signal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants