Skip to content

feat: add discover-driven filters for yarn lint, dig, git cherry-pick, git remote#1509

Open
xronocode wants to merge 2 commits intortk-ai:developfrom
xronocode:feat/discover-filters
Open

feat: add discover-driven filters for yarn lint, dig, git cherry-pick, git remote#1509
xronocode wants to merge 2 commits intortk-ai:developfrom
xronocode:feat/discover-filters

Conversation

@xronocode
Copy link
Copy Markdown

Summary

Adds 5 new filters identified by rtk discover --all as top unhandled commands across 92 sessions (3259 commands):

TOML filters (2 new):

  • yarn-lint.toml — strip progress noise, blank lines from yarn lint output
  • dig.toml — keep ANSWER section and query metadata, strip decorative headers

Rust filters (2 new, extending git.rs):

  • git cherry-pick — compact success output, preserve full conflict info
  • git remote — compact listing, deduplicate -v output, action commands → ok

Discover rules:

  • Added rules for yarn lint/test/build/check, dig, ssh
  • Extended git pattern to cover cherry-pick and remote
  • Added 6 new classification tests in discover/registry.rs

Testing

  • 1596 tests passed, 0 failed
  • All new TOML filters have inline [[tests.*]] fixtures
  • New discover registry tests cover all 5 commands
  • test_registry_covers_all_git_subcommands updated with cherry-pick and remote

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 25, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ xronocode
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@pszymkowiak pszymkowiak added effort-medium 1-2 jours, quelques fichiers enhancement New feature or request labels Apr 25, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

Type feature
🟢 Risk low

Summary

Adds discover-driven filters for yarn lint, dig, git cherry-pick, and git remote commands. Includes two new TOML filters (yarn-lint, dig), two new Rust-based git subcommand handlers (cherry-pick, remote), new discover classification rules for yarn/dig/ssh, and corresponding tests.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Analyzed automatically by wshm · This is an automated analysis, not a human review.

@xronocode xronocode changed the base branch from master to develop April 25, 2026 02:46
@xronocode xronocode closed this Apr 25, 2026
@xronocode xronocode deleted the feat/discover-filters branch April 25, 2026 02:47
@xronocode xronocode restored the feat/discover-filters branch April 25, 2026 02:52
@xronocode xronocode reopened this Apr 25, 2026
github-actions Bot and others added 2 commits April 25, 2026 07:54
…, git remote

Add 5 new filters identified by rtk discover --all as top unhandled
commands across 92 sessions (3259 commands):

TOML filters:
- yarn-lint.toml: strip progress noise, blank lines from yarn lint
- dig.toml: keep ANSWER section and metadata, strip decorative headers

Rust filters (git.rs):
- git cherry-pick: compact success output, preserve full conflict info
- git remote: compact listing, dedup -v output, action commands -> ok

Also updates discover rules and registry tests for all 5 commands,
restores original ssh.toml (already existed in repo), and bumps
builtin filter count from 59 to 61.
@xronocode xronocode force-pushed the feat/discover-filters branch from 9cfc337 to 68c0af7 Compare April 25, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort-medium 1-2 jours, quelques fichiers enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants