Skip to content

fix: uninstall Codex artifacts in global cleanup#1534

Open
will-r-wang wants to merge 1 commit intortk-ai:masterfrom
will-r-wang:ww/fix-codex-global-uninstall
Open

fix: uninstall Codex artifacts in global cleanup#1534
will-r-wang wants to merge 1 commit intortk-ai:masterfrom
will-r-wang:ww/fix-codex-global-uninstall

Conversation

@will-r-wang
Copy link
Copy Markdown

@will-r-wang will-r-wang commented Apr 26, 2026

Summary

  • Make rtk init -g --uninstall clean up global Codex and Gemini artifacts in addition to the existing global RTK uninstall flow.
  • Add a regression test covering global Codex uninstall behavior and keep targeted --codex --uninstall / --gemini --uninstall paths intact.
  • Clarify CLI/help text and installation docs so uninstall behavior matches what the command actually does.

Test plan

  • cargo fmt --all && cargo clippy --all-targets && cargo test
    • test result: ok. 1607 passed; 0 failed; 6 ignored; 0 measured; 0 filtered out; finished in 0.97s
  • cargo test uninstall -- --nocapture
  • Manual CLI smoke test: global Codex install + rtk init -g --uninstall with temp RTK_CLAUDE_DIR / CODEX_HOME, verified RTK.md and the AGENTS.md reference were removed
  • Manual CLI smoke test: global Gemini install + rtk init -g --uninstall with temp HOME, verified .gemini/GEMINI.md and .gemini/hooks/rtk-gemini.sh were removed

Important: All PRs must target the develop branch (not master).
See CONTRIBUTING.md for details.

@will-r-wang will-r-wang changed the base branch from master to develop April 26, 2026 00:12
@pszymkowiak pszymkowiak added bug Something isn't working documentation Improvements or additions to documentation effort-small Quelques heures, 1 fichier labels Apr 26, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

🐛 Type bug-fix
🟢 Risk low

Summary

This PR makes rtk init -g --uninstall clean up global Codex and Gemini artifacts in addition to Claude Code artifacts, ensuring the catch-all global uninstall removes everything. It also adds regression tests for global Codex uninstall behavior and updates CLI help text and installation docs to reflect the expanded uninstall scope.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Analyzed automatically by wshm · This is an automated analysis, not a human review.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 26, 2026

CLA assistant check
All committers have signed the CLA.

@will-r-wang will-r-wang changed the base branch from develop to master April 30, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation effort-small Quelques heures, 1 fichier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants