fix(npx): use npx (not npm) for unrecognized npx commands#762
Closed
lineardevon wants to merge 1 commit intortk-ai:developfrom
Closed
fix(npx): use npx (not npm) for unrecognized npx commands#762lineardevon wants to merge 1 commit intortk-ai:developfrom
lineardevon wants to merge 1 commit intortk-ai:developfrom
Conversation
Contributor
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
The Npx handler's catch-all fallback called npm_cmd::run(), which invoked `npm` instead of `npx`. When npx flags preceded the tool name (e.g. `npx -y -p @playwright/cli playwright-cli list`), args[0] was a flag, not a tool name, so routing fell to the catch-all — which then ran the wrong binary entirely. Replace with direct npx passthrough matching the existing prisma passthrough pattern. Preserves SKIP_ENV_VALIDATION, tracking, and exit code propagation. Fixes rtk-ai#713 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Devon Freitas <devon.freitas@gmail.com>
94f9320 to
fa361a5
Compare
Collaborator
|
Closing as #1458 has taken care of the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commands::Npxcatch-all fallback callednpm_cmd::run(), which invokednpminstead ofnpxnpx -y -p @playwright/cli playwright-cli list), routing fell to the catch-all and ran the wrong binaryFixes #713
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo test(1056 passed on develop)rtk npx tsc --versionandrtk npx playwright teststill route to specialized handlers