Repository navigation
Conversation
Morriar
marked this pull request as ready for review
November 5, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent malformed UTF-8 in inline RBS comments from raising
ArgumentError.CommentBlock#trailing_annotationidentified annotation comments using a regexp:For a comment containing malformed UTF-8, this operation raises before the annotation reaches the RBS parser:
Fix
Use literal prefix matching:
This check does not validate the rest of the comment as UTF-8. The malformed annotation therefore reaches the existing RBS lexer, which reports a parsing error.
CommentBlockconverts that error into anAnnotationSyntaxErrordiagnostic.Reproduction
A Ruby source containing a literal invalid byte in an inline annotation comment previously raised
ArgumentError:Tests
Added an end-to-end
Prism.parse→RBS::InlineParser.parseregression test covering:0xDD0xFF0xC30xE2 0x82Each case now produces
RBS::InlineParser::Diagnostic::AnnotationSyntaxErrorinstead of raisingArgumentError.