Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2518
Psych.safe_dumphas no signature, so type checkers that read these signatures do not know about it (castwide/solargraph#959):Psych.loadandPsych.load_filealso lack the keywordsloadhas taken since psych 4 made it safe by default:permitted_classes:,permitted_symbols:andaliases:. A YAML file with aliases or dates needs them, as inYAML.load_file("config/database.yml", aliases: true).This adds:
Psych.safe_dump, with the overloads ofPsych.dumppluspermitted_classes:,permitted_symbols:andaliases:permitted_classes:,permitted_symbols:,aliases:andstrict_integer:toPsych.loadandPsych.load_filestrict_integer:toPsych.safe_load,Psych.safe_load_fileandPsych.unsafe_load_file, whichPsych.unsafe_loadalready declaresstringify_names:toPsych.dumpandPsych.safe_dumpThe
safe_dumpcomment is generated byrake annotate.parse_symbols:(psych 5.3) is left out because the stdlib tests run with psych 4.0.6, which goodcheck pins in Gemfile.lock and which does not have it.