Skip to content

Comments

feat: remove RUDDERSTACK_PAT from Docker build#133

Merged
kuldeep0020 merged 3 commits intomainfrom
chore/remove-rudderstack-pat
Feb 23, 2026
Merged

feat: remove RUDDERSTACK_PAT from Docker build#133
kuldeep0020 merged 3 commits intomainfrom
chore/remove-rudderstack-pat

Conversation

@kuldeep0020
Copy link
Contributor

Summary

  • Remove RUDDERSTACK_PAT build argument from Dockerfile and Dockerfile.optimize
  • Stop baking the PAT into the profiles-mcp .env file at build time
  • Remove RUDDERSTACK_PAT secret from ECR and DockerHub build args in the CI workflow

Linear Task

@kuldeep0020 kuldeep0020 requested review from debanjan97 and tipped73 and removed request for debanjan97 February 18, 2026 12:29
debanjan97
debanjan97 previously approved these changes Feb 20, 2026
@debanjan97 debanjan97 dismissed their stale review February 20, 2026 05:16

Build is failing

@debanjan97
Copy link
Member

Build is failing, you need to install the new mcp without PAT requirement

@debanjan97 debanjan97 self-requested a review February 20, 2026 05:17
@kuldeep0020
Copy link
Contributor Author

Build is failing, you need to install the new mcp without PAT requirement

Made a release on profiles-mcp and using that here now.

@debanjan97
Copy link
Member

Build is failing, you need to install the new mcp without PAT requirement

Made a release on profiles-mcp and using that here now.

https://github.com/rudderlabs/profiles-mcp/blob/02b2f3476479f68ff13534153e0f4b88b749c639/scripts/env_setup.py#L10
unless we remove this, build will still fail

@github-actions
Copy link
Contributor

Docker Preview Images Ready

Preview Docker images have been built for this PR:

ECR (internal):

docker pull 422074288268.dkr.ecr.us-east-1.amazonaws.com/rudderstack/profiles-code-server:pr-133

DockerHub (public):

docker pull rudderstack/profiles-code-server:pr-133

Image Details:

  • Tag: pr-133
  • Platforms: linux/amd64, linux/arm64

Test the image:

docker run --rm -p 8080:8080 rudderstack/profiles-code-server:pr-133

Note: These preview images will be overwritten on subsequent pushes to this PR.

@kuldeep0020 kuldeep0020 changed the title chore: remove RUDDERSTACK_PAT from Docker build feat: remove RUDDERSTACK_PAT from Docker build Feb 23, 2026
@kuldeep0020 kuldeep0020 merged commit f7593e7 into main Feb 23, 2026
79 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants