Skip to content

render: Support rendering filters in BitmapData.draw #21672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

render: Support rendering filters in BitmapData.draw #21672

wants to merge 2 commits into from

Conversation

@kjarosh
Copy link
Member

@kjarosh kjarosh commented Sep 15, 2025 •
edited
Loading

@kjarosh kjarosh added A-rendering Area: Rendering & Graphics T-compat Type: Compatibility with Flash Player labels Sep 15, 2025
@kjarosh
Copy link
Member Author

kjarosh commented Sep 15, 2025 •
edited
Loading

Note that this PR fixes #12202 in terms of rendering filters, but breaks it in terms of scaling/positioning the bitmap.

I suspect this is an unrelated CAB bug, but I want to make sure (or even fix it) before merging this one.

@kjarosh
Copy link
Member Author

kjarosh commented Sep 15, 2025

Also, I have no idea what's up with avm2/away3d_advanced_shallow_water_demo, but its output is not from Flash anyway, and I can imagine CAB changed something (introduced a one-frame delay, or something).

@ChrisCPI ChrisCPI mentioned this pull request Sep 15, 2025
Open
@kjarosh kjarosh added the waiting-on-author Waiting on the PR author to make the requested changes label Sep 15, 2025
@Lord-McSweeney
Copy link
Collaborator

Lord-McSweeney commented Sep 15, 2025

This should also fix #15107

@Lord-McSweeney Lord-McSweeney mentioned this pull request Sep 15, 2025
Open
@kjarosh
Copy link
Member Author

kjarosh commented Sep 19, 2025

Note that this PR fixes #12202 in terms of rendering filters, but breaks it in terms of scaling/positioning the bitmap.

I suspect this is an unrelated CAB bug, but I want to make sure (or even fix it) before merging this one.

It's unrelated to this PR, it's even not related to CAB, fixed by #21698.

@kjarosh kjarosh force-pushed the bitmapdata-draw-cab branch from 52fc5fe to b2bc502 Compare September 19, 2025 20:43
@kjarosh kjarosh added waiting-on-review Waiting on review from a Ruffle team member and removed waiting-on-author Waiting on the PR author to make the requested changes labels Sep 19, 2025
@hamzaelbarmaki1994
Copy link

hamzaelbarmaki1994 commented Sep 20, 2025 •
edited
Loading

will this PR resolve #21509 ?

@kjarosh
Copy link
Member Author

kjarosh commented Sep 20, 2025

This actually breaks drawWithQuality. Will have to look into it

@kjarosh kjarosh added waiting-on-author Waiting on the PR author to make the requested changes and removed waiting-on-review Waiting on review from a Ruffle team member labels Sep 20, 2025
@kjarosh kjarosh force-pushed the bitmapdata-draw-cab branch from b2bc502 to c08bd27 Compare October 11, 2025 17:42
@kjarosh
Copy link
Member Author

kjarosh commented Oct 11, 2025

Constrained CAB rendering for the same quality only, this should fix the majority of content. We can implement CAB rendering for different qualities in the future.

@kjarosh kjarosh added waiting-on-review Waiting on review from a Ruffle team member and removed waiting-on-author Waiting on the PR author to make the requested changes labels Oct 11, 2025
Dinnerbone
Dinnerbone approved these changes Oct 12, 2025
View reviewed changes
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM but we need to figure out what's up with away3d_advanced_shallow_water_demo - it's failing the test now.

@Lord-McSweeney Lord-McSweeney added waiting-on-author Waiting on the PR author to make the requested changes and removed waiting-on-review Waiting on review from a Ruffle team member labels Oct 17, 2025
@kjarosh kjarosh force-pushed the bitmapdata-draw-cab branch from c08bd27 to ca2c80e Compare October 26, 2025 21:50
@kjarosh
tests: Add avm2/bitmapdata_draw_cab_quality test
557deca
@kjarosh
render: Support rendering filters in BitmapData.draw
9819c5e 
This patch adds support for CAB rendering in `BitmapData.draw` which
fixes missing filters. Currently it supports CAB rendering only with the
same quality due to how CAB is being implemented. In the future we
should also support CAB rendering with different qualities.
@kjarosh kjarosh force-pushed the bitmapdata-draw-cab branch from ca2c80e to 9819c5e Compare November 11, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dinnerbone Dinnerbone Dinnerbone approved these changes

Assignees

No one assigned

Labels

A-rendering Area: Rendering & Graphics newsworthy T-compat Type: Compatibility with Flash Player waiting-on-author Waiting on the PR author to make the requested changes

Projects

None yet

Milestone

No milestone

5 participants

@kjarosh @Lord-McSweeney @hamzaelbarmaki1994 @Dinnerbone @n0samu