Skip to content

Conversation

@moulins
Copy link
Contributor

@moulins moulins commented Nov 10, 2025

(part 4: #22186)

Migrates the web/* and tests/* crates; only core remains in edition 2021 now.

@moulins moulins added A-web Area: Web & Extensions A-tests Area: Tests & Test Framework T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Nov 10, 2025
@moulins
Copy link
Contributor Author

moulins commented Nov 10, 2025

Switching web/packages/extension/safari to edition 2024 causes objc's class! macro to fire this warning:

warning: unexpected `cfg` condition value: `cargo-clippy`
 --> web/packages/extension/safari/src/main.rs:8:63
  |
8 |         let mut ruffle = ClassDecl::new("RuffleWebExtension", class!(NSObject))
  |                                                               ^^^^^^^^^^^^^^^^
  |
  = note: no expected values for `feature`
  = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate
  = help: try referring to `class` crate for guidance on how handle this unexpected cfg
  = help: the macro `class` may come from an old version of the `objc` crate, try updating your dependency with `cargo update -p objc`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default
  = note: this warning originates in the macro `class` (in Nightly builds, run with -Z macro-backtrace for more info)

objc is unmaintained, so let's switch to the better-maintained objc2 instead.

EDIT: and now there's another failure... :c
EDIT 2: CI passes now, hopefully the safari extension builds properly... (I don't have an iPad/iPhone/iMac to test with)

@moulins moulins force-pushed the edition-2024-part5 branch 6 times, most recently from 75438df to 4743ad7 Compare November 10, 2025 09:52
@moulins moulins added the waiting-on-review Waiting on review from a Ruffle team member label Nov 10, 2025
@kjarosh kjarosh added A-other Area: Not covered by other area labels and removed A-web Area: Web & Extensions A-tests Area: Tests & Test Framework labels Nov 10, 2025
The `obj2` crate now causes a warning ("unexpected `cfg` condition value: `cargo-clippy`")
and is unmaintained, so this switches to the better-maintained `objc2` fork
(https://github.com/madsmtm/objc2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) waiting-on-review Waiting on review from a Ruffle team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants