Label resolver config driven #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a complete refactor of the envelope encryption API, transitioning from `network_id: Option<&str>` to `network_public_key: Option<&[u8]>` for improved consistency with the label resolver design. - Updated the `EnvelopeCrypto` trait and `SerializationContext` structure to reflect the new public key approach, enhancing validation and performance. - Implemented changes across multiple components, including NodeKeyManager and MobileKeyManager, to support the new encryption flow. - Ensured comprehensive testing and validation of all encryption and decryption flows, addressing potential breaking changes and enhancing overall security. - Updated documentation and migration steps to guide users through the transition to the new API structure.
- Implemented a complete refactor of the label resolver system, introducing `LabelResolverConfig` and `LabelValue` structures for improved configuration management. - Updated `NodeConfig` to include a mandatory `label_resolver_config` field, ensuring all nodes have a defined label mapping at startup. - Created a new example demonstrating the usage of the label resolver system, showcasing both system and user context resolutions. - Enhanced serialization context to support dynamic label resolution, improving flexibility and performance. - Added comprehensive tests for the label resolver configuration and its validation, ensuring robustness and correctness. - Updated various components to utilize the new label resolver structures, enhancing overall consistency across the codebase.
- Completed the update of the Node struct to replace `label_resolver` with `system_label_config`, optimizing performance. - Updated the Node constructor to utilize the new `config.label_resolver_config`. - Enhanced ResponseMessage, EventMessage, and RequestMessage structures by adding the `network_public_key` field for improved message handling. - Updated QuicTransport to replace static resolvers with the new system label configuration, ensuring consistency across the transport layer. - Fixed method signatures in the API to align with new trait requirements, enhancing overall code clarity.
…ize transport layer updates - Marked Phase 4 (Node Integration) and Phase 5 (Transport Layer Integration) as completed, reflecting significant progress in the project. - Updated the Node struct to utilize `system_label_config` instead of `label_resolver`, enhancing performance and clarity. - Enhanced message structures by adding `network_public_key` fields to various message types for improved handling. - Transitioned to dynamic resolver creation in SerializationContext, ensuring fresh user context for each request. - Fixed all NetworkMessagePayloadItem initializations to include the `network_public_key`, ensuring consistency across the transport layer. - Initiated Phase 6 (Testing and Validation) with all unit tests passing and integration tests confirmed for node and transporter functionalities.
- Completed integration of dynamic label resolver architecture across the Node and RemoteService components, replacing static resolvers with `label_resolver_config` for improved user context handling. - Updated message structures to consistently use `profile_public_keys: Vec<Vec<u8>>`, ensuring alignment across RequestMessage, ResponseMessage, and NetworkMessagePayloadItem. - Enhanced RequestContext to support multiple user profile keys, facilitating better context propagation. - Implemented dynamic resolver creation in both Node and RemoteService, ensuring fresh user context for each request. - Updated all relevant method signatures and serialization contexts to reflect the new API structure, enhancing overall consistency and clarity.
- Removed `RequestMessage`, `ResponseMessage`, and `EventMessage` structures, transitioning to a single `NetworkMessage` structure for all callbacks. - Updated the transport layer to consistently use `NetworkMessage`, enhancing clarity and reducing data duplication. - Refactored related components, including Node and RemoteService, to accommodate the new message structure, ensuring compatibility across the system. - Enhanced the label resolver configuration to support the new architecture, improving overall performance and maintainability. - Updated tests and examples to reflect the changes in message handling, ensuring comprehensive coverage and validation of the new structure.
- Updated the `EnvelopeCrypto` implementation in `NodeKeyManagerWrapper` to replace the previous envelope creation method with a new approach that incorporates `profile_public_keys`. - Enhanced the encryption process to support multiple profile keys, improving flexibility in data handling. - Ensured consistency with recent changes in message structures and encryption flows across the codebase.
…eKeyManagerWrapper
…ture - Deleted outdated documents related to envelope encryption, NodeKeyManager redesign, and Swift vector validation, streamlining the codebase. - Refactored the label resolver implementation to eliminate the trait overhead, replacing it with a concrete struct for improved performance and simplicity. - Enhanced the `LabelResolver` to utilize `DashMap` for concurrent access, ensuring efficient label resolution and cache management. - Updated related components and tests to align with the new label resolver structure, maintaining consistency across the system.
- Introduced a trait-based `LabelResolver` interface to enhance flexibility and decouple implementations. - Updated `ConfigurableLabelResolver` to implement the new trait, ensuring compatibility with existing functionality. - Modified method signatures across the codebase to accept the trait object, improving type safety and clarity. - Temporarily disabled cache performance tests due to the removal of the cache implementation, ensuring tests reflect current functionality. - Updated example usage to align with the new label resolver structure, demonstrating the validation process for system configurations.
- Updated the `LabelResolver` interface to delegate functionality to `ConfigurableLabelResolver`, enhancing clarity and maintainability. - Modified method signatures across the codebase to utilize the new trait, ensuring consistent usage of the label resolver. - Adjusted example and test cases to reflect the updated label resolver structure, confirming validation processes and resolver creation. - Improved type safety by replacing direct references to `LabelResolver` with `ConfigurableLabelResolver` where applicable.
- Removed obsolete mock transport implementation and related module to streamline test code. - Updated references to `LabelResolver` in the codebase, replacing them with `ConfigurableLabelResolver` for improved clarity and consistency. - Adjusted test cases to utilize the new label resolver structure, ensuring proper validation and functionality. - Cleaned up unnecessary comments and improved overall organization of the test files.
…olations - Introduced a new `clippy.toml` file to configure Clippy for detecting absolute path usage, setting the maximum allowed segments to 1. - Created a `format_fixes.md` document outlining identified qualified path violations across the codebase, detailing the number of violations found by Clippy and a manual scan. - Updated various test files to improve clarity by removing unused parameters and enhancing error message formatting. - Adjusted method signatures to accept slices instead of vectors for better performance and consistency. - Enhanced logging and documentation to support ongoing efforts in fixing qualified path violations systematically.
- Improved the logic for handling expired cache entries by separating the removal process from the cache retrieval to avoid potential deadlocks. - Introduced a flag to indicate whether an expired entry should be removed, enhancing clarity in the cache management process. - Updated performance tests to ensure proper validation of cache behavior during TTL expiration, maintaining consistency in testing.
- Introduced a new document outlining critical lessons learned from previous test management mistakes, emphasizing the importance of careful file handling and verification during test migrations. - Analyzed the current test structure and proposed a detailed migration plan to improve organization, maintainability, and performance across the Runar crates. - Established safe migration rules to prevent data loss and ensure successful test relocations, including moving fixtures to a centralized location and splitting mixed test files for clarity. - Updated various test files and structures to align with the new organization, enhancing clarity and reducing duplication. - Documented the expected issues and mitigation strategies related to API compatibility when moving tests between different compilation contexts.
…eter - Modified multiple service and context methods to accept an additional `options` parameter, enhancing flexibility in request and publish operations. - Updated relevant calls throughout the codebase to accommodate the new method signatures, ensuring consistency and improved functionality. - Cleaned up formatting and organization of method definitions for better readability.
- Added `tokio-test` as a development dependency to facilitate asynchronous testing. - Introduced `async-trait` to support async trait implementations in test utilities. - Created new test modules for improved organization, including comprehensive tests for `TopicPath` and `PathTrie`. - Updated existing tests to align with the new structure, ensuring better maintainability and clarity. - Documented recent API changes affecting migration patterns for method calls, enhancing migration guidance for developers.
- Modified multiple service and test files to include an additional `options` parameter in request method calls, enhancing flexibility and consistency across the codebase. - Updated relevant tests to reflect the new method signatures, ensuring proper functionality and maintainability. - Cleaned up formatting for improved readability and organization of the code.
- Documented critical issues with the main Clippy command not reporting `absolute_paths` violations, affecting PR verification. - Suggested solutions for CI/CD pipeline updates and wrapper script creation to ensure comprehensive Clippy checks. - Removed unused `LabelResolverConfig` references and related components from various files, streamlining the codebase. - Cleaned up test files by eliminating unnecessary parameters and improving organization for better maintainability.
- Updated the code formatting standards in `codeformat.mdc` to include checks for absolute paths and emphasized the use of IDE tools for code changes. - Improved import statements across multiple files for better clarity and organization, ensuring proper usage of modules and types. - Refactored `ArcValue` serialization and deserialization methods to utilize `serde_cbor` more effectively, enhancing overall code maintainability. - Streamlined the `ReplicationManager` and `QuicTransport` implementations by refining method calls and improving parameter handling for better consistency.
…ate module - Updated logging configuration to utilize `log::LevelFilter` directly, enhancing clarity and consistency in log level handling. - Refactored the `apply` method in `LoggingConfig` to streamline logger initialization and formatting. - Improved error handling in the certificate module by refining the conversion from various error types to `KeyError`, ensuring better error reporting. - Enhanced serialization and deserialization processes for `EcdsaKeyPair` and `X509Certificate` to utilize specific error types, improving maintainability and clarity. - Cleaned up import statements across multiple files for better organization and readability.
… consistency - Replaced direct calls to `serde_json` with imported functions `from_str` and `to_string_pretty` for better readability in `NodeConfig`. - Updated `InitCommand` to utilize `to_vec` and `from_slice` from `serde_cbor`, enhancing serialization processes. - Improved import organization across multiple files, ensuring clarity and reducing redundancy. - Streamlined QR code rendering by using the imported `QrCode` type directly, simplifying the code structure.
…clarity - Consolidated import statements across multiple files to enhance organization and reduce redundancy. - Updated method signatures in various services to utilize the `OnOptions` type, improving flexibility in event handling. - Streamlined type aliases and removed unnecessary qualifiers for better readability. - Improved the handling of asynchronous tasks by using consistent patterns for spawning tasks and managing handles.
…yers - Replaced direct calls to `create_context_label_resolver` with `get_or_create_resolver` method utilizing the new `label_resolver_cache` for improved performance and concurrency. - Updated `Node` and `RemoteService` structures to include a shared `label_resolver_cache` instance, enhancing efficiency in resolver creation. - Refactored relevant methods to ensure consistent usage of the cache, resulting in significant performance improvements for request handling and serialization processes. - Cleaned up import statements and removed unused global cache functionality to streamline the codebase.
- Introduced a `ResolverCache` to improve performance by reusing label resolvers in the label resolver example. - Updated the example to demonstrate cache creation, usage, and statistics, showcasing cache hit functionality. - Refactored method calls to utilize the cache for both system and user context resolvers, enhancing efficiency. - Improved comments for clarity and updated the configuration validation to use `ConfigurableLabelResolver` directly.
- Eliminated all references to label resolver functionality in the FFI and Node.js native APIs, including the removal of related struct fields, functions, and method signatures. - Updated TypeScript definitions to reflect the removal of the `setLabelMapping` method. - Cleaned up test cases to remove any dependencies on the now-removed label resolver functionality, ensuring tests focus on actual transport capabilities. - This change simplifies the API, reduces memory usage, and improves overall code clarity by removing dead code.
…tion - Modified comprehensive API and lifecycle tests to retrieve the network public key before encrypting data with an envelope, ensuring correct encryption behavior. - Updated error handling in the comprehensive API test to check for null manager type instead of 'network'. - Enhanced logging in lifecycle tests to include the size of the network public key for better debugging insights.
- Modified `completeRequest`, `request`, `requestToPublicKey`, `publish`, and `publishToPublicKey` methods to accept arrays of profile public keys and optional network public keys, enhancing flexibility in key management. - Updated TypeScript definitions and Rust implementation to reflect these changes, ensuring consistency across the API. - Adjusted related test cases to accommodate the new method signatures, improving overall test coverage and functionality.
- Updated `rn_transport_request`, `rn_transport_publish`, and `rn_transport_complete_request` functions to accept CBOR serialized parameters, improving data handling and flexibility. - Introduced new parameter structs for request, publish, and complete request operations, ensuring clear and structured data representation. - Modified tests to create and validate CBOR parameters, enhancing test coverage and ensuring compatibility with the new serialization approach. - Added `serde` dependency with derive features for easier serialization and deserialization.
…lementations - Eliminated `requestToPublicKey` and `publishToPublicKey` methods from the Transport class, simplifying the API and reducing redundancy. - Updated TypeScript definitions to reflect the removal of these methods, ensuring consistency across the codebase. - Adjusted related test cases to utilize the existing `request` and `publish` methods, maintaining functionality while improving clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.