Combine components into a more controllable interface to simplify new components #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentasm1
reviewed
Jul 2, 2025
Collaborator
valentasm1
left a comment
valentasm1
left a comment
There was a problem hiding this comment.
Honesly i am more conserned about js part, but c# part looks good. Also i dont think it is complex to optimize c#. Worst case use reflaction with some caching or some expressions.
| void SetDisposed(); | ||
| } | ||
|
|
||
| public enum MapComponentType |
Collaborator
There was a problem hiding this comment.
As i see you dont use it anywhere.
Contributor
Author
There was a problem hiding this comment.
I implemented them for each component: https://github.com/rungwiroon/BlazorGoogleMaps/pull/434/files#diff-987163f27f6bdfea202261756380d8e45309d03c83b67350cda463acf851cdb7R23
This way the user can easily filter the AdvancedMap.Components.Where(x => x.ComponentType is MapComponentType.Marker) and then do marker specific stuff is my thoughts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my suggestion for how to make it somewhat easier to work with, if the users want to get a component via the map they can use the .Components field and then filter based on the ComponentType. Registering new components would be a bit simpler and they can implement the interface to get it to work. This way users can implement their own components, apart from the fact that the events won't really work.
Settings this as a draft for now, until im sure this is a good solution and I will fix some other parts from the previous PR