CE-989 and CE-990 #210
Merged
CE-989 and CE-990 #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yhlong00
approved these changes
Nov 20, 2025
brosenpod
reviewed
Nov 20, 2025
cmd/croc/receive.go
Outdated
| Debug: false, | ||
| IsSender: false, | ||
| NoPrompt: true, | ||
| NoPrompt: true, |
Collaborator
There was a problem hiding this comment.
Nit: Trailing whitespace
Contributor
Author
There was a problem hiding this comment.
Good catch - fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CE-989:
Right now, we support a custom "secret code" via send (--code) However this results in a literal insertion which overrides our custom code definition.
This results in receive failing as we expect 4 hyphens in order to work. The only hyphens that matter is the final one which denotes the relay.
Correct this behavior so we accept custom codes.
CE-990:
Right now we use a hardcoded version file which makes version incrementing difficult as one has to remember to manually increment it.
Move to a programatic version where we use the following form:
<version number>-<git hash>This way we can verify what the codebase was at the time of build.