Add type-correcting projections on pointer cast and related operations#937
Merged
Add type-correcting projections on pointer cast and related operations#937
Conversation
…nter cast, not connected yet
Member
Author
|
Tested a selection of p-token proofs and short-running SPL proofs, all were passing with these changes. |
dkcumming
approved these changes
Feb 11, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
Nice, I think let's give this a try. I imagine we will have to make adjustments for other cases as we find more out but I think this is a great improvement as is
Comment on lines
+1118
to
+1120
| // requires LENGTH +Int PTR_OFFSET <=Int ORIGIN_SIZE // refuse to create an invalid fat pointer | ||
| // andBool dynamicSize(1) ==K #metadataSize(lookupTy(_TY)) // expect a slice type | ||
| // andBool hasIndexTail(PROJS) ??? |
Collaborator
There was a problem hiding this comment.
Should these conditions be present?
automergerpr-permission-manager bot
pushed a commit
to runtimeverification/solana-token
that referenced
this pull request
Feb 11, 2026
- [More BinOp::Offset tests More BinOp::Offset tests](runtimeverification/mir-semantics#935) - [fix: type of offset for applyBinOp(binOpOffset, ...) fix: type of offset for applyBinOp(binOpOffset, ...)](936) - [Add type-correcting projections on pointer cast and related operations](runtimeverification/mir-semantics#937)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appendPfunction is adjusted to do these cancellations.iterator_simpletest is now passing.