Corrections to Multisig cheatcodes#942
Merged
automergerpr-permission-manager[bot] merged 2 commits intofeature/p-tokenfrom Feb 17, 2026
Merged
Corrections to Multisig cheatcodes#942automergerpr-permission-manager[bot] merged 2 commits intofeature/p-tokenfrom
Multisig cheatcodes#942automergerpr-permission-manager[bot] merged 2 commits intofeature/p-tokenfrom
Conversation
automergerpr-permission-manager
bot
merged commit 8293833
into
feature/p-token
7 checks passed
automergerpr-permission-manager
bot
deleted the
dc/multisig-cheatcode-corrections
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cheatcode previously left the signers of the multisig as an existential
?SIGNERSrepresenting the whole list. This meant that the proof state could not make progress without a more detailed form. Now the cheatcode explicitly lists out each of the 11 Signers asKey(?Signer<N>)where0 <= N < 11. Each of these signers is also restricted to be 32 bytes by predicates in theensuresclause e.g.:size(?Signer0) ==Int 32 andBool allBytes(?Signer0). This change has been tested and makes progress with theInitializeMultisigproof (P-Token).