Skip to content

hrp len const fn #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apoelstra merged 1 commit into from
Feb 9, 2025
Merged

hrp len const fn #212

apoelstra merged 1 commit into from
Feb 9, 2025

Conversation

@tzemanovic
Copy link
Contributor

@tzemanovic tzemanovic commented Feb 7, 2025

makes the Hrp::len a const fn

clarkmoody
clarkmoody approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@clarkmoody clarkmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 72ad45a

@tcharding
Copy link
Member

tcharding commented Feb 7, 2025

What is the motivation? Just because we can and its better? If so perhaps we do FieldVec::len at the same time. I checked all the other len functions and they are all ExactSizedIterator trait methods so cannot be const.

@apoelstra
Copy link
Member

apoelstra commented Feb 8, 2025

Every pure function should be const, unless there are compiler limitations (such as them being trait methods) that prevent it, or we expect to run into compiler limitations with future refactorings.

apoelstra
apoelstra approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 72ad45a; successfully ran local tests

@apoelstra apoelstra merged commit a19e843 into rust-bitcoin:master Feb 9, 2025
15 checks passed
@nazar-pc nazar-pc mentioned this pull request May 12, 2025
Closed
@nazar-pc
Copy link

nazar-pc commented May 12, 2025

Could someone publish a new release with this change, please?

@tcharding tcharding mentioned this pull request May 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@clarkmoody clarkmoody clarkmoody approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tzemanovic @tcharding @apoelstra @nazar-pc @clarkmoody