Skip to content

clippy: fix collapsible_match lint #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phimuemue merged 2 commits into from
Apr 16, 2026
+11 −17
Merged

clippy: fix collapsible_match lint #1099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3cef1d
clippy: fix collapsible_match lint
xtqqczze Apr 15, 2026
348e1ba
refactor: replace match with a single if let guard
xtqqczze Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions src/groupbylazy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,11 @@ where

while let Some(elt) = self.next_element() {
let key = self.key.call_mut(&elt);
match self.current_key.take() {
None => {}
Some(old_key) => {
if old_key != key {
self.current_key = Some(key);
first_elt = Some(elt);
break;
}
if let Some(old_key) = self.current_key.take() {
if old_key != key {
self.current_key = Some(key);
first_elt = Some(elt);
break;
}
}
self.current_key = Some(key);
Expand Down Expand Up @@ -248,15 +245,12 @@ where
None => None,
Some(elt) => {
let key = self.key.call_mut(&elt);
match self.current_key.take() {
None => {}
Some(old_key) => {
if old_key != key {
self.current_key = Some(key);
self.current_elt = Some(elt);
self.top_group += 1;
return None;
}
if let Some(old_key) = self.current_key.take() {
if old_key != key {
self.current_key = Some(key);
self.current_elt = Some(elt);
self.top_group += 1;
return None;
}
}
self.current_key = Some(key);
Expand Down
Loading