Repository navigation
Repository: require mutable references to change the namespace - #1343
Open
DanielEScherzer wants to merge 1 commit into
Open
DanielEScherzer wants to merge 1 commit into
DanielEScherzer wants to merge 1 commit into
Conversation
DanielEScherzer
force-pushed
the
repo-mut-set-namespace
branch
from
November 14, 2026 20:00
0b6ad95 to
8f12b25
Compare
set_namespace() and set_namespace_bytes() as mutating
Contributor
Author
|
@rustbot label +semver-breaking-change |
This comment has been minimized.
This comment has been minimized.
Require a mutable reference to `self` because the namespace is being changed, which is a mutable operation. If allowed on just a `&self` immutable reference, the existing namespace (read with `get_namespace()` or `get_namespace_bytes()`) can be used after libgit2 has already freed it. Affects: - `Repository::set_namespace()` - `Repository::set_namespace_bytes()` - `Repository::remove_namespace()` Since the error messages are different on different versions of Rust, update the GitHub actions setup to use the correct expected output based on the tested version. Work towards rust-lang#1330
DanielEScherzer
force-pushed
the
repo-mut-set-namespace
branch
from
November 17, 2026 19:13
8f12b25 to
c2b127e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require a mutable reference to
selfbecause the namespace is being changed, which is a mutable operation. If allowed on just a&selfimmutable reference, the existing namespace (read withget_namespace()orget_namespace_bytes()) can be used after libgit2 has already freed it.Affects:
Repository::set_namespace()Repository::set_namespace_bytes()Repository::remove_namespace()Since the error messages are different on different versions of Rust, update the GitHub actions setup to use the correct expected output based on the tested version.
Work towards #1330