fix : incorrect POLLOUT def on horizonOS/armv6k-nintendo-3ds#5090
Draft
kore-signet wants to merge 1 commit intorust-lang:mainfrom
Draft
fix : incorrect POLLOUT def on horizonOS/armv6k-nintendo-3ds#5090kore-signet wants to merge 1 commit intorust-lang:mainfrom
kore-signet wants to merge 1 commit intorust-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current definition for POLLOUT is incorrect - as described here, it should be 0x08.
Unfortunately, it seems like the current definition for POLLERR is overlapping as 0x08. According to the linked docs, POLLERR is actually not a supported operation on this target (neither is POLLHUP, which is also currently defined).
I'm not super clear on what the best procedure would be here - should POLLERR & POLLHUP be deleted as definitions?
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
(libc-test does not currently support horizonOS, as far as I can tell?)