Check arguments of attributes where no arguments are expected#155193
Check arguments of attributes where no arguments are expected#155193JonathanBrouwer wants to merge 14 commits intorust-lang:mainfrom
Conversation
|
cc @rust-lang/wg-const-eval Some changes occurred in compiler/rustc_attr_parsing |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Check arguments of attributes where no arguments are expected
This comment has been minimized.
This comment has been minimized.
3231b2a to
15b2265
Compare
|
Try build cancelled. Cancelled workflows: |
Check arguments of attributes where no arguments are expected
This comment has been minimized.
This comment has been minimized.
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
15b2265 to
10495f2
Compare
This comment has been minimized.
This comment has been minimized.
10495f2 to
e6fe0e7
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
☔ The latest upstream changes (presumably #155483) made this pull request unmergeable. Please resolve the merge conflicts. |
This PR does the following:
rustc_attr_parsing, to ensure we never forget to check the arguments of a meta item again#[derive(Clone)]fromArgParseras that would break this debug assertion#[inline(always(...))]gets no arguments#[instruction_set(arm::a32(...))]gets no arguments#[macro_export(local_inner_macros(...))]gets no arguments.Fixes Invalid value accepted for
#[macro_export(local_inner_macros)]#154977#[used(compiler(...))]gets no arguments.#[optimize(size(...))]gets no arguments.#[coverage(on(...))]gets no arguments.#[rustc_dump_layout(debug(...))]gets no arguments.#[rustc_abi(debug(...))]gets no arguments.#![test_runner(arg(...))]gets no arguments.#[rustc_must_implement_one_of(arg(...))]gets no arguments.#[rustc_allow_const_fn_unstable(arg(...))]gets no arguments.#[rustc_if_this_changed(arg(...))]gets no arguments.#[rustc_then_this_would_need(arg(...))]gets no arguments.r? @jdonszelmann