Add a missing GenericTypeVisitable, and avoid having interner traits for FnSigKind and Abi#155562
Open
ChayimFriedman2 wants to merge 2 commits intorust-lang:mainfrom
Open
Add a missing GenericTypeVisitable, and avoid having interner traits for FnSigKind and Abi#155562ChayimFriedman2 wants to merge 2 commits intorust-lang:mainfrom
GenericTypeVisitable, and avoid having interner traits for FnSigKind and Abi#155562ChayimFriedman2 wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
no-traits
branch
from
7ec1c80 to
d3e8dd3
Compare
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
no-traits
branch
from
d3e8dd3 to
bd82b59
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
no-traits
branch
from
40a86de to
237818c
Compare
This comment has been minimized.
This comment has been minimized.
Instead, just use the concrete types `FnSigKind` and `rustc_abi::ExternAbi`. This simplifies the code in both rustc and rust-analyzer.
ChayimFriedman2
force-pushed
the
no-traits
branch
from
237818c to
83b29b6
Compare
oli-obk
reviewed
Apr 22, 2026
nikomatsakis
approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Seems like a win to me.
If I'm following, @ChayimFriedman2, this basically gives you more shared code that can be reused?
Contributor
Author
|
Yes. As long as r-a and rustc don't need to diverge, we should prefer to share the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? types