Skip to content

privacy: document unordered visibility limit#155792

Closed
SynapLink wants to merge 1 commit intorust-lang:mainfrom
SynapLink:document-unordered-effective-vis
Closed

privacy: document unordered visibility limit#155792
SynapLink wants to merge 1 commit intorust-lang:mainfrom
SynapLink:document-unordered-effective-vis

Conversation

@SynapLink
Copy link
Copy Markdown

Follow-up to #155257.\n\nWhile investigating the FIXME in EffectiveVisibilities::update, the unordered case comes from restricted visibilities forming a tree: restrictions to sibling modules are incomparable. This documents the current behavior for the nominal visibility limit case, where the inherited effective visibility is preserved because there is no single Visibility that can represent the intersection.\n\nNo behavior change.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 25, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 25, 2026

r? @nikomatsakis

rustbot has assigned @nikomatsakis.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@petrochenkov
Copy link
Copy Markdown
Contributor

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned nikomatsakis Apr 26, 2026
@petrochenkov
Copy link
Copy Markdown
Contributor

The FIXME is mostly for me, I'd like to find specific examples on which this code is triggered, whether they can be turned into errors, and what the update operation means for them if they are not errors.
A trivial LLM-generated explanation won't do.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2026
@SynapLink
Copy link
Copy Markdown
Author

@petrochenkov
The FIXME is mostly for me, I'd like to find specific examples on which this code is triggered, whether they can be turned into errors, and what the update operation means for them if they are not errors.
A trivial LLM-generated explanation won't do.

Im sorry. Ive used llm to summarize the whole thing, but i genuinely want to contribute to the repo, are there opened problems which needs to be solved or would you suggest some other thing, sorry for disturbing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants