Skip to content

Support defaults for static EIIs#156583

Open
AsakuraMizu wants to merge 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-static-default
Open

Support defaults for static EIIs#156583
AsakuraMizu wants to merge 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-static-default

Conversation

@AsakuraMizu
Copy link
Copy Markdown
Contributor

@AsakuraMizu AsakuraMizu commented May 14, 2026

Tracking issue: #125418

#154193 added EII support for statics, but left default implementations for "a followup PR". This PR implements it.

Maybe I should remove no-prefer-dynamic if #156577 is accepted.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

mu001999
mu001999 approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mu001999 mu001999 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I’ll defer to @JonathanBrouwer in case I’ve missed anything.

r? JonathanBrouwer

View changes since this review

@rustbot rustbot assigned JonathanBrouwer and unassigned mu001999 May 15, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 15, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented May 15, 2026

I'm currently on holidays but would like to take a look, might take me a few days to get around to it

@AsakuraMizu AsakuraMizu force-pushed the eii-static-default branch from 81c9617 to d7f16d7 Compare May 15, 2026 19:27
JonathanBrouwer
JonathanBrouwer approved these changes May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup
Looks good, thanks!
Wanted to implement this immediately after my PR that implemented static EIIs but forgot :3

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 17, 2026

📌 Commit d7f16d7 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented May 17, 2026

@bors r=JonathanBrouwer,mu001999

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 17, 2026

📌 Commit d7f16d7 has been approved by JonathanBrouwer,mu001999

It is now in the queue for this repository.

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 17, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156583 - AsakuraMizu:eii-static-default, r=…
27adf3d 
…JonathanBrouwer,mu001999

Support defaults for static EIIs

Tracking issue: rust-lang#125418

rust-lang#154193 added EII support for statics, but left default implementations for "a followup PR". This PR implements it.

Maybe I should remove `no-prefer-dynamic` if rust-lang#156577 is accepted.
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 17, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 17, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156583 - AsakuraMizu:eii-static-default, r=…
f8115dc 
…JonathanBrouwer,mu001999

Support defaults for static EIIs

Tracking issue: rust-lang#125418

rust-lang#154193 added EII support for statics, but left default implementations for "a followup PR". This PR implements it.

Maybe I should remove `no-prefer-dynamic` if rust-lang#156577 is accepted.
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 17, 2026
Closed
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented May 18, 2026

@bors r-
#156679 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 18, 2026

This pull request was unapproved.

This PR was contained in a rollup (#156679), which was unapproved.

View changes since this unapproval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

@mu001999 mu001999 mu001999 approved these changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AsakuraMizu @rustbot @JonathanBrouwer @mu001999