Skip to content

querify getting fake doc items - #161200

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mejrs:fake_item_queries
Sep 13, 2026
Merged

querify getting fake doc items#161200
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mejrs:fake_item_queries

Conversation

@mejrs

@mejrs mejrs commented Aug 16, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 16, 2026
@mejrs

mejrs commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 16, 2026
@bors
Auto merge of #161200 - mejrs:fake_item_queries, r=<try>
f21c600 
querify getting fake doc items
@rust-bors

rust-bors Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: f21c600 (f21c6005f028eabfec72893ab56022b3891a81f0)
Base parent: 34baba5 (34baba5394fcbda4cba7b7c1964a6db421c77c91)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f21c600): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.2% [0.1%, 0.3%] 2
Improvements ✅
(primary)		 -0.7% [-2.6%, -0.1%] 27
Improvements ✅
(secondary)		 -1.4% [-2.6%, -0.3%] 52
All ❌✅ (primary) -0.7% [-2.6%, -0.1%] 27

Max RSS (memory usage)

Results (primary 0.3%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.3% [0.7%, 1.9%] 4
Regressions ❌
(secondary)		 1.7% [0.7%, 2.5%] 4
Improvements ✅
(primary)		 -1.1% [-1.5%, -0.5%] 3
Improvements ✅
(secondary)		 -2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) 0.3% [-1.5%, 1.9%] 7

Cycles

Results (primary 2.0%, secondary -6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.5% [-30.8%, -1.6%] 7
All ❌✅ (primary) 2.0% [2.0%, 2.0%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 455.832s -> 457.539s (0.37%)
Artifact size: 399.69 MiB -> 399.63 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 17, 2026
@mejrs mejrs mentioned this pull request Aug 17, 2026
Merged
@mejrs
mejrs marked this pull request as ready for review August 17, 2026 11:17
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2026
@rustbot

rustbot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 16 candidates

@mejrs
mejrs force-pushed the fake_item_queries branch from 2956a4e to a46b0ca Compare August 17, 2026 11:32
@camelid

camelid commented Aug 20, 2026

Copy link
Copy Markdown
Member

r? @camelid

@rustbot rustbot assigned camelid and unassigned dingxiangfei2009 Aug 20, 2026
@mejrs

mejrs commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

r? compiler

@rustbot rustbot assigned ShoyuVanilla and unassigned camelid Sep 3, 2026
@mejrs
mejrs force-pushed the fake_item_queries branch from a46b0ca to 71584d5 Compare September 3, 2026 12:34
@rustbot

This comment has been minimized.

Sign in to view
@camelid

camelid commented Sep 3, 2026

Copy link
Copy Markdown
Member

Oh sorry for the review delay but I was actually reviewing this yesterday. I'll post a finished review asap.

@camelid camelid self-assigned this Sep 3, 2026
@mejrs

mejrs commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Oh sorry, I kinda glanced over the manual assignment 😳

camelid
camelid reviewed Sep 8, 2026
View reviewed changes

@camelid camelid left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple of comments.

View changes since this review

Comment thread compiler/rustc_metadata/src/rmeta/decoder.rs
Comment thread compiler/rustc_passes/src/fake_doc_items.rs Outdated
Comment thread src/librustdoc/clean/types.rs
Comment thread compiler/rustc_passes/src/fake_doc_items.rs
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026
@mejrs
mejrs force-pushed the fake_item_queries branch from 71584d5 to 72e0459 Compare September 8, 2026 21:28
@rustbot

This comment has been minimized.

Sign in to view
@mejrs

mejrs commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2026
@rust-bors

This comment has been minimized.

Sign in to view
camelid
camelid approved these changes Sep 12, 2026
View reviewed changes

@camelid camelid left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me with conflicts fixed

View changes since this review

Comment thread compiler/rustc_passes/src/fake_doc_items.rs
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2026
@rustbot

rustbot commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@mejrs

mejrs commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

@bors r=camelid

@rust-bors

rust-bors Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8123f4a has been approved by camelid

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 12, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2026
@rust-bors

rust-bors Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: camelid
Duration: 3h 1m 17s
Pushing 3fcfc54 to main...

@rust-bors
rust-bors Bot merged commit 3fcfc54 into rust-lang:main Sep 13, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 13, 2026
@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 809936e (parent) -> 3fcfc54 (this PR)

Test differences

Show 12 test diffs

12 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3fcfc54fbc5bb8a84763ab3aba440ce5e5cd30ea --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-i686-gnu-nopt-1: 1h 32m -> 2h 20m (+51.9%)
  2. test-x86_64-msvc-ext2: 1h 9m -> 1h 44m (+50.5%)
  3. dist-aarch64-apple: 2h 27m -> 1h 28m (-40.1%)
  4. test-x86_64-gnu-llvm-21-2: 1h 11m -> 1h 34m (+32.1%)
  5. test-i686-msvc: 2h 34m -> 1h 47m (-30.4%)
  6. dist-x86_64-llvm-mingw: 2h 18m -> 1h 37m (-29.2%)
  7. test-x86_64-gnu-aux: 2h 30m -> 1h 47m (-28.4%)
  8. test-x86_64-gnu-tools: 1h 10m -> 50m 39s (-28.2%)
  9. test-i686-gnu-nopt-2: 2h 31m -> 1h 49m (-27.8%)
  10. dist-armv7-linux: 1h 16m -> 1h 37m (+27.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3fcfc54): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-2.6%, -0.1%] 29
Improvements ✅
(secondary)		 -1.5% [-2.6%, -0.2%] 49
All ❌✅ (primary) -0.6% [-2.6%, -0.1%] 29

Max RSS (memory usage)

Results (primary 0.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.9% [0.6%, 1.4%] 4
Regressions ❌
(secondary)		 4.3% [2.4%, 8.0%] 4
Improvements ✅
(primary)		 -1.2% [-1.7%, -0.6%] 3
Improvements ✅
(secondary)		 -3.0% [-4.1%, -2.4%] 3
All ❌✅ (primary) 0.0% [-1.7%, 1.4%] 7

Cycles

Results (primary -0.1%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.7% [0.5%, 1.0%] 6
Regressions ❌
(secondary)		 8.0% [2.2%, 18.3%] 3
Improvements ✅
(primary)		 -1.3% [-2.6%, -0.7%] 4
Improvements ✅
(secondary)		 -2.4% [-3.0%, -1.8%] 4
All ❌✅ (primary) -0.1% [-2.6%, 1.0%] 10

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.0% [-0.1%, -0.0%] 4
Improvements ✅
(secondary)		 -0.0% [-0.1%, -0.0%] 2
All ❌✅ (primary) -0.0% [-0.1%, -0.0%] 4

Bootstrap: 493.911s -> 495.498s (0.32%)
Artifact size: 406.90 MiB -> 407.03 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels

merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mejrs @rust-timer @rustbot @camelid @dingxiangfei2009 @ShoyuVanilla