Rollup of 20 pull requests - #161458
Rollup of 20 pull requests#161458
Conversation
- be explicit when only needing types of `GenericArgs`
This comment has been minimized.
This comment has been minimized.
Rollup of 20 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-* try-job: x86_64-mingw-1 try-job: i686-msvc-*
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b662191 (parent) -> a872286 (this PR) Test differencesShow 364 test diffsStage 1
Stage 2
Additionally, 338 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a872286d0a1873caec0291ed4304de3170adbe16 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (a872286): comparison URL. Overall result: ❌ regressions - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 9.1%, secondary 7.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.4%, secondary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 470.067s -> 468.499s (-0.33%) |
|
📌 Perf builds for each rolled up PR:
parent commit: b66219142c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
|
Rollup of 20 pull requests Successful merges: - rust-lang#161259 (move some attribute related structs out of rustc_attr_ir) - rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings) - rust-lang#161161 (proc_macro: add support for 16-bit targets) - rust-lang#159899 ( `GenericArgs::types` triage + possible fixes) - rust-lang#160459 (Use attribute parser for `deprecated` attribute checking) - rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization) - rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection) - rust-lang#160595 (Clarify `str::split_at` docs) - rust-lang#160813 (Optimize linked list iterator performance) - rust-lang#161271 (doc: document safety requirements for core WTF-8) - rust-lang#161317 (LLVM 24: configure float-abi via module flag) - rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow) - rust-lang#161369 (Add regression test for confusing lifetime error message issue) - rust-lang#161393 (Configure LLM policy URL for triagebot) - rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB) - rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation) - rust-lang#161415 (Update expect messages in path docs to better follow guidelines) - rust-lang#161438 (Change triagebot backport to ping T-libs-fcp) - rust-lang#161442 (Add regression test for dead code on type alias used in impl self type) Failed merges: - rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) implement [u8]::split_ascii_whitespace format fix
Rollup of 20 pull requests Successful merges: - rust-lang#161259 (move some attribute related structs out of rustc_attr_ir) - rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings) - rust-lang#161161 (proc_macro: add support for 16-bit targets) - rust-lang#159899 ( `GenericArgs::types` triage + possible fixes) - rust-lang#160459 (Use attribute parser for `deprecated` attribute checking) - rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization) - rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection) - rust-lang#160595 (Clarify `str::split_at` docs) - rust-lang#160813 (Optimize linked list iterator performance) - rust-lang#161271 (doc: document safety requirements for core WTF-8) - rust-lang#161317 (LLVM 24: configure float-abi via module flag) - rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow) - rust-lang#161369 (Add regression test for confusing lifetime error message issue) - rust-lang#161393 (Configure LLM policy URL for triagebot) - rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB) - rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation) - rust-lang#161415 (Update expect messages in path docs to better follow guidelines) - rust-lang#161438 (Change triagebot backport to ping T-libs-fcp) - rust-lang#161442 (Add regression test for dead code on type alias used in impl self type) Failed merges: - rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`) implement [u8]::split_ascii_whitespace format fix
|
I'm aligned with not investigating further given codegen scheduling is usually @rustbot label +perf-regresssion-triaged |
This comment was marked as resolved.
This comment was marked as resolved.
|
@rust-timer triage 77433e4 50d6ab8 37fdff8 b9e823b 0ba17bc 839342e 039ca27 8126620 31639bd |
Running triage with 2 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#161259 77433e4 move some attribute related structs out of rustc_attr_irThis perf run didn't have relevant results for the `instruction count` metric.Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #160853 50d6ab8 delegation: simplify matches on
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
3.5% | [3.5%, 3.5%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 3.5% | [3.5%, 3.5%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#161161 37fdff8 proc_macro: add support for 16-bit targets
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#159899 b9e823b GenericArgs::types triage + possible fixes
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary 3.5%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
3.5% | [3.5%, 3.5%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 3.5% | [3.5%, 3.5%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#160459 0ba17bc Use attribute parser for deprecated attribute checking
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (primary 3.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
3.6% | [3.6%, 3.6%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 3.6% | [3.6%, 3.6%] | 1 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#160536 839342e Inline String::into_raw_parts and reuse from_utf16 optimization
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#160563 039ca27 Make BorrowedCursor<'a, T> covariant in 'a and drop an indirection
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
1.1% | [1.1%, 1.1%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 1.1% | [1.1%, 1.1%] | 1 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
Results (primary 1.3%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
1.3% | [0.1%, 5.0%] | 4 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 1.3% | [0.1%, 5.0%] | 4 |
#160813 8126620 Optimize linked list iterator performance
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#161317 31639bd LLVM 24: configure float-abi via module flag
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
Successful merges:
FnKind, minor refactorings #160853 (delegation: simplify matches onFnKind, minor refactorings)GenericArgs::typestriage + possible fixes #159899 (GenericArgs::typestriage + possible fixes)deprecatedattribute checking #160459 (Use attribute parser fordeprecatedattribute checking)String::into_raw_partsand reusefrom_utf16optimization #160536 (InlineString::into_raw_partsand reusefrom_utf16optimization)BorrowedCursor<'a, T>covariant in'aand drop an indirection #160563 (MakeBorrowedCursor<'a, T>covariant in'aand drop an indirection)str::split_atdocs #160595 (Clarifystr::split_atdocs)RUST_MIN_STACKif maybe stack overflow #161320 (Only suggestRUST_MIN_STACKif maybe stack overflow)letto avoid UB #161403 (splat-fn-ptr-ptr-tuple.rs: addletto avoid UB)tests/rustdoc-gui/notable-trait.gomltest #161409 (Add backtests/rustdoc-gui/notable-trait.gomltest)documentationscope documentation #161410 (Fix rustdoc remappingdocumentationscope documentation)Failed merges:
RegionExt; move methods toRegioninrustc_type_ir#160509 (RemoveRegionExt; move methods toRegioninrustc_type_ir)r? @ghost
Create a similar rollup