Merged
Conversation
lqd
reviewed
Apr 21, 2026
| | All ❌✅ (primary) | 1.1% | [-0.5%, 16.9%] | 37 | | ||
|
|
||
| - This PR introduced performance regressions caused by wrong CGU estimates. | ||
| - They were later fixed in [#155491](https://github.com/rust-lang/rust/pull/155491). |
Member
There was a problem hiding this comment.
there seem to be less improvements in 155491 than regressions in 142531, so are they really fixed?
Member
Author
There was a problem hiding this comment.
I was mostly worried about the three large regressions. Apart from that, the PR should have caused more optimization opportunities, so I think that the small opt regressions are kinda warranted.
nnethercote
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered