Skip to content

comparison_summary.rs: update comment when not adding rollup=never #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kobzol merged 3 commits into from
Apr 23, 2026
+11 −3
Merged

comparison_summary.rs: update comment when not adding rollup=never #2431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3ef51b
comparison_summary.rs: update comment when not adding rollup=never
DanielEScherzer Apr 23, 2026
db4feaf
Run `cargo fmt`
DanielEScherzer Apr 23, 2026
ba13f0a
Remove leading newline
DanielEScherzer Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions site/src/github/comparison_summary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,21 @@ fn try_run_body(is_regression: bool, deserves_attention: bool) -> String {
""
};

// If perf does not deserve attention, don't say that the PR was automatically marked as not fit for rolling up
// But point out that it can be manually marked as such
let rollup_comment = if deserves_attention {
"It's automatically marked not fit for rolling up. \
Overriding is possible but disadvised: \
it risks changing compiler perf."
} else {
"Consider adding rollup=never if this change is not fit for rolling up."
};

let sign = if is_regression { "+" } else { "-" };
format!(
"
Benchmarking means the PR may be perf-sensitive. \
It's automatically marked not fit for rolling up. \
Overriding is possible but disadvised: \
it risks changing compiler perf.{next_steps}
{rollup_comment}{next_steps}

{rollup_never}
@rustbot label: -S-waiting-on-perf {sign}perf-regression",
Expand Down
Loading