Skip to content

Dedup changed benchmarks list #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kobzol merged 1 commit into from
Sep 1, 2026
+8 −2
Merged

Dedup changed benchmarks list #2563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions site/src/github/triage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,14 @@ pub async fn changed_benchmarks_in_rollup(
});
// Include newly failed benchmarks so we can triage which PRs broke them
let newly_failed_benchmarks = comparison.newly_failed_benchmarks.into_keys();
let changed_benchmarks = compile_benchmarks.chain(newly_failed_benchmarks);
Ok(changed_benchmarks.collect())

let mut changed_benchmarks = compile_benchmarks
.chain(newly_failed_benchmarks)
.collect::<Vec<_>>();
changed_benchmarks.sort();
changed_benchmarks.dedup();

Ok(changed_benchmarks)
}

#[cfg(test)]
Expand Down
Loading