refactor: apply clippy::skip_while_next#6914
Closed
shulaoda wants to merge 1 commit into
Closed
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Going to close until we decide on which clippy lints we want to enforce in the codebase. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/string.rs::break_string, replaces bothskip_while(|p| !is_valid_linebreak(input, *p)).next()calls withfind(|p| is_valid_linebreak(input, *p)).clippy::skip_while_next, run as a single-rule pass:cargo clippy -- -A clippy::all -W clippy::skip_while_next.Iterator::skip_while(pred).next()returns the first element for which the predicate is false, so inverting the predicate insideskip_whileis equivalent to usingIterator::finddirectly. The rewrite drops the!and the trailing.next().