Skip to content

refactor: apply clippy::get_first#6915

Closed
shulaoda wants to merge 1 commit into
rust-lang:mainfrom
shulaoda:05-23-refactor_apply_clippy_get_first
Closed

refactor: apply clippy::get_first#6915
shulaoda wants to merge 1 commit into
rust-lang:mainfrom
shulaoda:05-23-refactor_apply_clippy_get_first

Conversation

@shulaoda
Copy link
Copy Markdown
Contributor

Summary

  • In src/overflow.rs, replaces lists.get(0)? with lists.first()? in last_item_shape, and args.get(0)? with args.first()? in maybe_get_args_offset.
  • Addresses clippy::get_first, run as a single-rule pass: cargo clippy -- -A clippy::all -W clippy::get_first.

slice::first() and slice::get(0) return identical Option<&T> values; preferring first() makes the intent explicit.

@rustbot rustbot added the S-waiting-on-review Status: awaiting review from the assignee but also interested parties. label May 22, 2026
@ytmimi
Copy link
Copy Markdown
Contributor

ytmimi commented May 22, 2026

Going to close until we decide on which clippy lints we want to enforce in the codebase.

@ytmimi ytmimi closed this May 22, 2026
@rustbot rustbot removed the S-waiting-on-review Status: awaiting review from the assignee but also interested parties. label May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants