feat: add optional tracing performance spans#125
feat: add optional tracing performance spans#125syphar wants to merge 4 commits intorust-lang:mainfrom
Conversation
| ManagedByRustwide(PathBuf), | ||
| } | ||
|
|
||
| impl fmt::Debug for Binary { |
There was a problem hiding this comment.
Please add a code comment explaining why you didn't derive it instead (I suppose it's because you want to skip the enum's name but please still write it down).
There was a problem hiding this comment.
I was thinking too much yesterday, changed to be the derive
| source_dir_mount_kind: MountKind, | ||
| } | ||
|
|
||
| impl fmt::Debug for Command<'_, '_> { |
There was a problem hiding this comment.
the impl itself I only added so it's easier to add the important Command info to the tracing spans. Not using the derive because I didn't want some things that might be noisy (env), and others don't have their own Debug impl (SandboxBuilder, and process_lines).
I updated the impl to it's more near to what I would expect from a "normal" debug impl.
There was a problem hiding this comment.
Then add a code comment to explain that. ;)
There was a problem hiding this comment.
I added a comment (and, admitted, udpated the impl again 😅 )
2 participants
I want to dig deeper on optimizing build speed, and first step is measuring where exactly we spend time.