Skip to content

prevent open redirect in doc-router lambda #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoieni merged 1 commit into from
Apr 30, 2026
Merged

prevent open redirect in doc-router lambda #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion terragrunt/modules/release-distribution/lambdas/doc-router/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@ exports.handler = (event, context, callback) => {

// Docs used to be under /doc, so redirect those for now
if (request.uri.startsWith('/doc/')) {
return redirect(request.uri.slice(4), callback);
// Collapse repeated slashes to prevent open redirect vulnerabilities.
// E.g. this prevents paths like `/doc//example.com` from redirecting
// to `https://example.com`.
const redirectTarget = request.uri.slice(4).replace(/\/+/g, '/');

return redirect(redirectTarget, callback);
}

// The `/stable`, `/beta`, and `/nightly` urls are all workable as-is
Expand Down
2 changes: 2 additions & 0 deletions terragrunt/modules/release-distribution/lambdas/doc-router/test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ test("example expected redirects", async (t) => {
// /doc
{ from: "/doc/std", to: "/std" },
{ from: "/doc/hello", to: "/hello" },
// Test that repeated slashes are collapsed to prevent open redirect vulnerabilities
{ from: "/doc//example.com/something", to: "/example.com/something" },
];

for (const redir of redirects) {
Expand Down
Loading