Porting some intrinsics to stdarch-gen-arm#2100
Open
sayantn wants to merge 6 commits intorust-lang:mainfrom
Open
Porting some intrinsics to stdarch-gen-arm#2100sayantn wants to merge 6 commits intorust-lang:mainfrom
sayantn wants to merge 6 commits intorust-lang:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
davidtwco
approved these changes
May 5, 2026
This enables the `big_endian_inverse` transformation to apply to this intrinsic.
This enables the `big_endian_inverse` transformation to apply to these intrinsics.
This enables the `big_endian_inverse` transform to apply to these intrinsics.
This enables the `big_endian_inverse` transform to apply to this intrinsic.
This enables the `big_endian_inverse` transform to apply to this intrinsic.
Manually written tests for `vcopy_laneq`, `vget{,q}_{high,low,lane}`,
`vcombine` and `vaddw_high` don't account for the expected differences
in output for big endian intrinsics and given that they duplicate the
testing of `intrinsic-test`, can be removed.
Collaborator
|
r? @Amanieu rustbot has assigned @Amanieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These intrinsics were implemented in
aarch64/neon/mod.rs, so this PR ports them to stdarch-gen-arm. All the edits are by @davidtwco, I have just cherry-picked from his branch and putting up the PR