Skip to content

add 8,80GeV pythia8 jets and update double interactions#4249

Merged
pinkenburg merged 2 commits intosPHENIX-Collaboration:masterfrom
pinkenburg:add-types
Apr 15, 2026
Merged

add 8,80GeV pythia8 jets and update double interactions#4249
pinkenburg merged 2 commits intosPHENIX-Collaboration:masterfrom
pinkenburg:add-types

Conversation

@pinkenburg
Copy link
Copy Markdown
Contributor

@pinkenburg pinkenburg commented Apr 15, 2026

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This PR adds 8 and 80 GeV pythia8 jets. It also updates the available double interaction samples. No jenkins test: [skip-ci]

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Summary

This PR adds new Pythia8 jet samples and expands double-interaction production support in the file catalog configuration script.

Motivation

Support new lower and higher pT jet threshold measurements for sPHENIX analyses, and enable double-interaction studies (overlapping minimum-bias events) for a broader range of existing jet and photon-jet productions.

Key Changes

  • New production types added:

    • Type 48: Pythia8 jets with ptmin = 8 GeV (supports --double double-interaction mode)
    • Type 49: Pythia8 jets with ptmin = 80 GeV (standard production only)
  • Expanded double-interaction support: Extended --double flag capability to production types 11, 19, 21, 27, 29, 34, and 39 using sprintf-based filename transformation to append _pythia8_Detroit suffix

  • Description metadata: Added entries for types 48 and 49 in %proddesc dictionary with consistent GeV spacing formatting across all descriptions

  • Embedding and pileup: Both new types support standard embedding modes (pau, central, oo) and pileup configuration options like existing jet samples

Potential Risk Areas

  • File naming consistency: Ensure downstream tools correctly parse the new pythia8_Jet8 and pythia8_Jet80 filenames and map them to appropriate reconstruction parameters
  • Double-interaction production: Type 48 with --double flag generates pythia8_Jet8_pythia8_Detroit filenames; verify this naming matches physical data expectations and won't conflict with existing cataloging
  • Sample discovery: Users must be aware of new production type IDs (48, 49) to request these samples

Future Improvements

  • Document the production type registry (mapping of type IDs to physics processes) in a human-readable reference
  • Consider automation for consistent description formatting

Note: AI assistance was used to generate this summary. Please verify that the production type assignments and double-interaction capabilities align with experimental requirements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

📝 Walkthrough

Walkthrough

This change updates the production type descriptions and extends double-event handling in the file list creation framework. It modifies string formatting for existing production types, adds descriptions for two new types, and implements --double filename transformation logic across multiple production type branches.

Changes

Cohort / File(s) Summary
Production type descriptions and double-event handling
offline/framework/frog/CreateFileList.pl
Updated %proddesc entries for types 11, 12, 17–19, 21, 27–29, 33–36, 38–39 with corrected spacing around GeV; added descriptions for prodtypes 48 and 49. Extended --double behavior for types 11, 19, 21, 27, 29, 33, 34, 48 by appending _pythia8_Detroit suffix via sprintf. Refactored prodtype 39's hardcoded --double transformation to use sprintf-based approach. Added new branches for prodtypes 48 and 49 with filename string definitions and pileup/embed logic.

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
offline/framework/frog/CreateFileList.pl (2)

1411-1411: Minor indentation inconsistency.

Line 1411 has extra leading whitespace before elsif compared to all other production type branches.

Suggested fix
-        elsif ($prodtype == 49)
+    elsif ($prodtype == 49)

1286-1314: Pre-existing issue: Duplicate prodtype == 45 block.

This block (lines 1286-1314) duplicates the earlier block at lines 1257-1285. The second block is unreachable dead code. This predates the current PR but worth noting for future cleanup.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a8e29623-f553-4849-b0b7-ae5e64e1b6ee

📥 Commits

Reviewing files that changed from the base of the PR and between 9ada433 and 7fcb80b.

📒 Files selected for processing (1)
  • offline/framework/frog/CreateFileList.pl

@pinkenburg pinkenburg merged commit 8584e34 into sPHENIX-Collaboration:master Apr 15, 2026
1 check passed
@pinkenburg pinkenburg deleted the add-types branch April 15, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant