add 8,80GeV pythia8 jets and update double interactions#4249
add 8,80GeV pythia8 jets and update double interactions#4249pinkenburg merged 2 commits intosPHENIX-Collaboration:masterfrom
Conversation
📝 WalkthroughWalkthroughThis change updates the production type descriptions and extends double-event handling in the file list creation framework. It modifies string formatting for existing production types, adds descriptions for two new types, and implements Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
offline/framework/frog/CreateFileList.pl (2)
1411-1411: Minor indentation inconsistency.Line 1411 has extra leading whitespace before
elsifcompared to all other production type branches.Suggested fix
- elsif ($prodtype == 49) + elsif ($prodtype == 49)
1286-1314: Pre-existing issue: Duplicateprodtype == 45block.This block (lines 1286-1314) duplicates the earlier block at lines 1257-1285. The second block is unreachable dead code. This predates the current PR but worth noting for future cleanup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a8e29623-f553-4849-b0b7-ae5e64e1b6ee
📒 Files selected for processing (1)
offline/framework/frog/CreateFileList.pl
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
This PR adds 8 and 80 GeV pythia8 jets. It also updates the available double interaction samples. No jenkins test: [skip-ci]
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Summary
This PR adds new Pythia8 jet samples and expands double-interaction production support in the file catalog configuration script.
Motivation
Support new lower and higher pT jet threshold measurements for sPHENIX analyses, and enable double-interaction studies (overlapping minimum-bias events) for a broader range of existing jet and photon-jet productions.
Key Changes
New production types added:
--doubledouble-interaction mode)Expanded double-interaction support: Extended
--doubleflag capability to production types 11, 19, 21, 27, 29, 34, and 39 usingsprintf-based filename transformation to append_pythia8_DetroitsuffixDescription metadata: Added entries for types 48 and 49 in
%proddescdictionary with consistent GeV spacing formatting across all descriptionsEmbedding and pileup: Both new types support standard embedding modes (pau, central, oo) and pileup configuration options like existing jet samples
Potential Risk Areas
pythia8_Jet8andpythia8_Jet80filenames and map them to appropriate reconstruction parameters--doubleflag generatespythia8_Jet8_pythia8_Detroitfilenames; verify this naming matches physical data expectations and won't conflict with existing catalogingFuture Improvements
Note: AI assistance was used to generate this summary. Please verify that the production type assignments and double-interaction capabilities align with experimental requirements.