Protoype of refactoring work with Test code too. Pushing these commit…#2

Draft

sachintaMSFT wants to merge 8 commits intomasterfrom

RefactorToEnableCOMAPI

Owner

sachintaMSFT commented Mar 19, 2021

Protoype of refactoring work with Test code too. Pushing these commits for a draft PR.


          Protoype of refactoring work with Test code too. Pushing these commit…

f3cf86a

…s for a draft PR.

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/COMContext.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/COMContext.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/COMContext.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/COMContext.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/Workflows/WorkflowBase.cpp Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLI/main.cpp Outdated

               {
-                  return AppInstaller::CLI::CoreMain(argc, argv);
+                  AppInstaller::CLI::TestCOMScenario();
+                  return 0;

JohnMcPMS Mar 19, 2021

You could just write a unit test to do this, and it might be something work checking in.

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/Core.cpp Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/Core.cpp Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/COMContext.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/COMContext.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/ExecutionContext.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/ExecutionReporter.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/ExecutionReporter.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/ExecutionReporter.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/ExecutionReporter.h Outdated Show resolved Hide resolved

JohnMcPMS suggested changes

View reviewed changes

JohnMcPMS left a comment

🕐


          Incorporated review comments to the Prototype.

3e4881b

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/Workflows/WorkflowBase.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCommonCore/Public/AppInstallerProgress.h Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/ExecutionReporter.cpp Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/ChannelStreams.cpp Outdated Show resolved Hide resolved

JohnMcPMS reviewed

View reviewed changes

src/AppInstallerCLICore/COMContext.cpp Outdated Show resolved Hide resolved


          Incorporate Feedback comments

d705fda

sachintaMSFT commented

View reviewed changes

src/AppInstallerCLI/AppInstallerCLI.vcxproj Outdated Show resolved Hide resolved

JohnMcPMS commented Mar 25, 2021

Seems good to make the real PR; no guarantees that I won't have comments there, but they won't be major.

SaChinta-MSFT added 4 commits

March 25, 2021 14:59


          Removing Dev Test Code for formal PR

f671327


          Fixing one self comment

a7f704b


          Addressing SpellCheck pipeline failure

3a33558


          Fixing Spellcheck case

10b3e55


          Incorporated review comments

b90b2ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet