Skip to content

Fix dropdown not opening after closing #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dropdown not opening after closing #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/Select.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,6 +1317,10 @@ export default {
onSearchKeyDown(e) {
const preventAndSelect = (e) => {
e.preventDefault()
if (!this.open) {
this.open = true
return
}
return !this.isComposing && this.typeAheadSelect()
}

Expand Down
9 changes: 9 additions & 0 deletions tests/unit/Dropdown.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ describe('Toggling Dropdown', () => {
expect(Select.vm.search).toEqual('')
})

it('should open dropdown on selectOnKeyCodes keydown', async () => {
const Select = mountDefault()
const input = Select.findComponent({ ref: 'search' })

input.trigger('keydown.enter')

expect(Select.vm.open).toEqual(true)
})

it('should open dropdown on alphabetic input', async () => {
const Select = mountDefault()
const input = Select.findComponent({ ref: 'search' })
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/Keydown.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ describe('Custom Keydown Handlers', () => {

const spy = jest.spyOn(Select.vm, 'typeAheadSelect')

Select.vm.open = true
Select.findComponent({ ref: 'search' }).trigger('keydown.space')

expect(spy).toHaveBeenCalledTimes(1)
Expand All @@ -33,6 +34,7 @@ describe('Custom Keydown Handlers', () => {

const spy = jest.spyOn(Select.vm, 'typeAheadSelect')

Select.vm.open = true
Select.findComponent({ ref: 'search' }).trigger('keydown.space')
expect(onKeyDown.mock.calls.length).toBe(1)

Expand Down