Conversation
Contributor
Author
|
@jonathaningram Could you please help to review this PR? Because some pdf or docx files have many pages and take a lot of time to parse text, I think a limitation is needed. |
Member
|
@xiaoxin01 thank you for the PR. We'll take a look over it and get back to you as soon as possible. This PR changes the API surface of the package a fair bit so we'll want to look into those changes and we'll discuss here. |
| t.Fatalf("got error = %v, want nil", err) | ||
| } | ||
|
|
||
| resp, _, err := ConvertPDF(f) |
Member
There was a problem hiding this comment.
@xiaoxin01 I think the best approach for supporting this kind configuration is to introduce new Converters. Something like:
package docconv
type PDFConverter struct {
pageRange []int
maxWords int
}
func NewPDFConverter(pageRange []int, maxWords int) *PDFConverter {
return &PDFConverter{
pageRange: pageRange,
maxWords: maxWords,
}
}
func (c *PDFConverter) Convert(r io.Reader) (string, map[string]string, error) {
// ...
}We want to avoid anymore global package state so I think a solution like this is probably going to be better. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large file will cause memory leak, so add char/page limit function.