docs: define PPR and cache components policy - #94
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughCache Components / PPR の対象ルートと制約を文書化し、 ChangesCache Components / PPR 方針
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/design.md`:
- Line 1472: Update the date in the `@opennextjs/cloudflare` upstream issue
statement to 2026-07-27 or remove the date entirely, and recheck the issue
status at merge time.
- Around line 509-516: docs/design.md の ReviewUserContent コード例に、使用している
ReviewRunner と loadReview をそれぞれ client/components/review-runner および
server/load-review から明示的に import する記述を追加し、TypeScript でコンパイル可能にしてください。
- Around line 1474-1475: Update the OpenNext issue summaries at docs/design.md
lines 1474-1475 and docs/frontend-architecture.html lines 562-563: describe
`#1130` as the production-only SyntaxError/crash with Suspense rendering failure,
and `#1225` as the Suspense streaming issue that results in “Connection closed.”
In `@docs/frontend-architecture.html`:
- Around line 1064-1069:
統一されていないレビューキューのローダー名を、docs/design.mdで定義された正式名称に合わせる。ReviewUserContentのloadReviewQueue参照と関連するimportをloadReviewへ変更し、補助資料内でもload-review.tsのloadReview()契約を一貫して使用する。
- Line 769: Update the Mermaid diagram flow line containing page, userContent,
serverLoader, rpcWrapper, and endpoint so every Mermaid arrow greater-than
character is HTML-escaped as -->. Preserve the rendered Mermaid text and
diagram behavior while satisfying HTMLHint spec-char-escape.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6c134a80-4796-49e7-9936-c753f226fd6e
📒 Files selected for processing (2)
docs/design.mddocs/frontend-architecture.html
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
1 participant
概要
Issue #92（#78 のフェーズ0）として、Next.js Cache Components / PPR の導入方針を設計文書に確定します。
将来の対象ルート、安全なユーザー固有データの扱い、OpenNext既知制約と有効化条件を明文化しました。
主な変更点
cacheComponentsの将来対象を/と/reviewに限定'use cache'を使わず、静的シェルと非キャッシュの動的領域を<Suspense>で分離/learn/...・/quiz/...は content 由来の SSG/RSC を維持docs/frontend-architecture.htmlを一次ソースのdocs/design.mdと同期関連 Issue
refs #92
refs #78
スクリーンショット（必要に応じて）
UI変更なし
変更の種類
テスト
pnpm typecheckpnpm biome check .（126 files）pnpm test（91 passed）git diff --checkチェックリスト
追加の注意事項
初期レビューの指摘6件（ローカル1件、CodeRabbit 5件）は
5035af6で修正済みです。修正増分はローカルreviewer 2件がapproveし、CodeRabbit Appの増分レビューでも
追加のactionable commentはありませんでした。