Skip to content

Conversation

@denis-ismailaj
Copy link

Fixes #603

@salesforce-cla
Copy link

salesforce-cla bot commented Dec 2, 2023

Thanks for the contribution! Before we can merge this, we need @denis-ismailaj to sign the Salesforce Inc. Contributor License Agreement.

@denis-ismailaj
Copy link
Author

I have signed the CLA

@denis-ismailaj
Copy link
Author

This does raise the dependency requirement of LAVIS to be transformers>=4.35 though.
If that is an issue, _expand_mask could be copied instead.

@coffeeexistence
Copy link

Updating transformers gives me the following error:

line 24, in __init__
    assert transformers_version < version.parse("4.27"), "BLIP models are not compatible with transformers>=4.27, run pip install transformers==4.25 to downgrade"

@coffeeexistence
Copy link

It's worth noting that both modeling_llama.py and modeling_opt.py in this repo have copied _expand_mask from transformers. Perhaps there is an opportunity for consolidation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLIP] cannot import name '_expand_mask'

2 participants