Configuration readability improvement, fix Vagrantfile and fix service watch#7
Open
amontalban wants to merge 9 commits intosaltstack-formulas:masterfrom
Open
Configuration readability improvement, fix Vagrantfile and fix service watch#7amontalban wants to merge 9 commits intosaltstack-formulas:masterfrom
amontalban wants to merge 9 commits intosaltstack-formulas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
This PR address the following things:
pillar.examplethe configuration looked like:Now it looks like:
Fix Vagrantfile to work and also allow to change
pillar.examplein the host and have it available in the VM. Additionally I usedlinked_cloneto improve tear down/creation times.When the pillar don't include
mail_alertsetting the service failed to start due to thewatchstatement, so I did the other way around by usingwatch_in.Add support for FreeBSD.
Allow to change other Monit settings like daemon interval or syslog. Also instead of passing the context to template files I import the map directly.
Allow to configure the service status (In my use case I need the service to be enabled but not running).
Thanks!