Skip to content

Catch exceptions for when endpoints isn't connected #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −9
Open

Catch exceptions for when endpoints isn't connected #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions RedLockNet.SERedis/RedLock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ private async Task<bool> UnlockInstanceAsync(RedisConnection cache)
var host = GetHost(cache.ConnectionMultiplexer);

var result = false;

try
{
logger.LogTrace($"UnlockInstanceAsync enter {host}: {redisKey}, {LockId}");
Expand Down Expand Up @@ -589,13 +589,19 @@ internal static string GetHost(IConnectionMultiplexer cache)

foreach (var endPoint in cache.GetEndPoints())
{
var server = cache.GetServer(endPoint);

result.Append(server.EndPoint.GetFriendlyName());
result.Append(" (");
result.Append(server.IsSlave ? "slave" : "master");
result.Append(server.IsConnected ? "" : ", disconnected");
result.Append("), ");
try
{
var server = cache.GetServer(endPoint);
result.Append(server.EndPoint.GetFriendlyName());
result.Append(" (");
result.Append(server.IsSlave ? "slave" : "master");
result.Append(server.IsConnected ? "" : ", disconnected");
result.Append("), ");
}
catch (ArgumentException)
{
// swallow exception, the endpoint is not connected
}
}

if (result.Length >= 2)
Expand Down Expand Up @@ -717,4 +723,4 @@ internal void StopKeepAliveTimer()
}
}
}
}
}