Repository navigation
Align with the Samebase repository standards - #4
Merged
Merged
Conversation
- Pin Node 24 in .node-version and set engines to Node >=24.11.0 and pnpm >=11.18.0. - Add the prepare script (vp config --no-agent), the staged block, and .vite-hooks/pre-commit. - Build lib/ with vp pack: declarations and source maps, then publint and attw (esm-only profile). A publint or attw finding fails the build. Delete tsconfig.build.json. - Run the live tests through scripts/test-live.ts, so the env var works on Windows too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- SECURITY.md: the Samebase base template text. - AGENTS.md: the ownership rule, Vite+ commands, test fixtures, live tests, automation, docs, and releases. - README: the live test script, the Node and pnpm versions, the pre-commit hook, and the release flow from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributors pin Node 24 through .node-version; consumers on Node 22 and any pnpm must not get engine warnings from this package. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the repository with the Samebase base template standards. No behavior change and no version bump, so the release workflow publishes nothing.
Changes
.node-versionis24.enginesis{ "node": ">=24.11.0", "pnpm": ">=11.18.0" }. Both workflows already usenode-version: 24.preparerunsvp config --no-agent.vite.config.tshas the templatestagedblock ("*": "vp check --fix")..vite-hooks/pre-commitrunsvp staged. The generated.vite-hooks/_/ignores itself, as in the template.pnpm run buildrunsvp pack. Thepackblock invite.config.tswriteslib/index.js,lib/index.d.ts, and their source maps, then runs publint and attw. attw uses theesm-onlyprofile, because the package is ESM only (the strict profile reports the node10 and node16-cjs modes).failOnWarnmakes a publint or attw finding fail the build.fixedExtension: falsekeepsindex.js, the file thatexportsnames. New devDependencies:publintand@arethetypeswrong/core. Deletedtsconfig.build.jsonand therewriteRelativeImportExtensionssetting.test:liverunsnode ./scripts/test-live.ts. The script setsALCHEMY_WORKERS_BUILDS_LIVE=1in the child environment, startsvp test --run test/livethrough Node, and forwards the exit code. It works on Windows.tsconfig.jsonnow includesscripts.SECURITY.mdfrom the template. A shortAGENTS.mdwith the repository rules, including the ownership rule. README: the live test script, the Node and pnpm versions, the pre-commit hook, and the release flow (the old text said to push av*tag).Results
pnpm run check: pass. Format, lint, and typecheck are clean. Tests: 4 files passed, 3 skipped; 79 tests passed, 3 skipped (the live tests).pnpm run build: pass.lib/index.js33.06 kB,lib/index.d.ts13.45 kB, and the maps. attw: no problems found. publint: no issues found.lib/index.jsare the same 9 names as the previoustscbuild.pnpm install --frozen-lockfileinstalls the hook and passescheckandbuild.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.