Skip to content

v316: Fix refresh after Firecrawl research cancellation - #210

Merged
nicu-chiciuc merged 1 commit into
mainfrom
nicu-fix-cancelled-research-refresh
Sep 23, 2026
Merged

nicu-chiciuc merged 1 commit into
mainfrom
nicu-fix-cancelled-research-refresh

Conversation

@nicu-chiciuc

@nicu-chiciuc nicu-chiciuc commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Admin research refresh failed when Firecrawl still reported a cancelled job as processing, then rejected cancellation with HTTP 409, Agent is already cancelled. Accept that exact response from the cancellation endpoint so refresh can start a new research job under the existing six-minute limit. Other conflicts and provider failures still block refresh, and completed results remain recoverable.

Return provider SDK failures as ConvexError with the method, path, message, HTTP status, and error code. The site page displays that detail instead of the generic production server error. Update the required hackathon log.

Validation:

  • Reproduced the stale processing status and the exact HTTP 409 response against the previously cancelled Firecrawl job.
  • Regression coverage verifies a fresh job can complete after that response, historical task research stays unchanged, unrelated conflicts still block refresh, and the UI displays provider details.
  • pnpm run check passed: 1,668 tests passed, 11 skipped. No production deployment or new production research run.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@nicu-chiciuc nicu-chiciuc changed the title v315: Fix refresh after Firecrawl research cancellation v316: Fix refresh after Firecrawl research cancellation Sep 23, 2026
@nicu-chiciuc
nicu-chiciuc force-pushed the nicu-fix-cancelled-research-refresh branch from cb1a7f9 to e5f75c7 Compare September 23, 2026 00:32
@nicu-chiciuc
nicu-chiciuc merged commit 9c9ed75 into main Sep 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant