(WIP) fix(build): pre-commit/CI checks fail on a clean main#66
Draft
RedCanti wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(build): pre-commit/CI checks fail on a clean
mainDescription
Two repository tooling checks fail on a fresh checkout of
main, independent of any feature code:pdm.lockcontent hash is stale. It was generated by an older PDM, sopdm lock --check(and frozen installs / CI) fail under PDM 2.27.0 even though no dependencies changed. This PR regenerates the hash no dependency versions are altered (only thecontent_hashline changes).[tool.towncrier]omitteddirectory, so towncrier resolved fragments to<package_dir>/<package>/newsfragments(peat/PEAT/newsfragments), which does not exist. Fragments actually live in the top-levelnewsfragments/(perCONTRIBUTING.rst), sotowncrier build/checksilently found nothing, meaning any branch adding a fragment fails thetowncrier-checkpre-commit hook. This PR setsdirectory = "newsfragments".Verified locally:
pdm lock --checkto a clean exit, thenpdm run towncrier build --draftnow renders fragments under Features; full suite passes (364 passed, 18 skipped).Related Issue
Closes: #65
Checklist
CHANGELOG.rst