Skip to content

(WIP) fix(build): pre-commit/CI checks fail on a clean main#66

Draft
RedCanti wants to merge 1 commit into
sandialabs:mainfrom
RedCanti:bug/precommit-check-fails
Draft

(WIP) fix(build): pre-commit/CI checks fail on a clean main#66
RedCanti wants to merge 1 commit into
sandialabs:mainfrom
RedCanti:bug/precommit-check-fails

Conversation

@RedCanti
Copy link
Copy Markdown

@RedCanti RedCanti commented Jun 1, 2026

fix(build): pre-commit/CI checks fail on a clean main

Description

Two repository tooling checks fail on a fresh checkout of main, independent of any feature code:

  • pdm.lock content hash is stale. It was generated by an older PDM, so pdm lock --check (and frozen installs / CI) fail under PDM 2.27.0 even though no dependencies changed. This PR regenerates the hash no dependency versions are altered (only the content_hash line changes).
  • Towncrier fragments directory. [tool.towncrier] omitted directory, so towncrier resolved fragments to <package_dir>/<package>/newsfragments (peat/PEAT/newsfragments), which does not exist. Fragments actually live in the top-level newsfragments/ (per CONTRIBUTING.rst), so towncrier build/check silently found nothing, meaning any branch adding a fragment fails the towncrier-check pre-commit hook. This PR sets directory = "newsfragments".

Verified locally: pdm lock --check to a clean exit, then pdm run towncrier build --draft now renders fragments under Features; full suite passes (364 passed, 18 skipped).

Related Issue

Closes: #65

Checklist

  • This PR conforms to the process detailed in the Contributing Guide
  • I have included no proprietary/sensitive information in my code
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - N/A no documentation changes required.
  • My changes generate no new warnings
  • I have tested my code
  • I have added a description of my changes to the changelog in CHANGELOG.rst
  • Apply appropriate Tags to this PR, if any (e.g. bugfix, enhancement(feature), documentation, etc.)
  • Removing "Draft" status from the PR (if applicable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Towncrier and pdm.lock checks fail on main

1 participant