feat: configure mime/type option #453
Open
+117
−112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves audio file handling in the Mux plugin and adds configurable MIME type validation. It builds upon the work from PR #398 by @isaac-martin.
This is a step forward in addressing issue #382, which calls for better audio file handling and support in the plugin, although there's still work to be done.
What to review
acceptedMimeTypesconfiguration option that allows configuring which file types are accepted by the input ('video/*'and/or'audio/*'). Default value is['video/*', 'audio/*']README.mdwith comprehensive documentation for theacceptedMimeTypesconfiguration optionTesting
Schema including the different options:
Try uploading audios, videos and other unsupported file types in the different uploaders. Verify that each uploader accepts only the file types specified in its
acceptedMimeTypesconfiguration (by default, accepts both audio and video files). After uploading an audio, check that the preview displays correctly.