feat(presence sensor): add duration parsing and fix lightLevel mask #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse `duration` from manufacturer data bytes 8-9 (big-endian). - Expand `lightLevel` bitmask from 0x0F to 0x1F to support observed values > 15 (e.g., 20). - Update unit tests to reflect these changes.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
|
@zerzhang If this is a good fix, you should have rights to review and merge |
bdraco
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the advertisement parser for the Presence Sensor.
Changes
durationparsing: Parse bytes 8-9 (big-endian). This value represents the duration of the current state (time elapsed since motion was detected or cleared).lightLevelmask: Expand the bitmask from0x0Fto0x1F.Motivation / Context
While testing with a real device, I observed a raw
lightLevelvalue of 20 (0b10100).The previous mask
0x0F(0b01111) truncated this value, resulting in incorrect data. Expanding the mask to0x1F(0b11111) correctly captures values > 15.This update complements the initial support added in #410.