ARSN-531: record server access log fields in s3routes

[leif-scality]

Extract fields to be used by cloudserver to write the server access logs

[bert-e]

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-531 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.2.34

• 8.3.0

Please check the Fix Version/s of ARSN-531, or the target
branch of this pull request.

[codecov]

Codecov Report

❌ Patch coverage is 63.63636% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.36%. Comparing base (2a414c8) to head (6c46d6c).

Files with missing lines	Patch %	Lines
lib/auth/AuthInfo.ts	40.00%	15 Missing ⚠️
lib/s3routes/routesUtils.ts	82.60%	4 Missing ⚠️
lib/s3routes/routes.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.2    #2554      +/-   ##
===================================================
- Coverage            71.40%   71.36%   -0.04%     
===================================================
  Files                  221      221              
  Lines                17816    17865      +49     
  Branches              3681     3691      +10     
===================================================
+ Hits                 12721    12750      +29     
- Misses                5091     5111      +20     
  Partials                 4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-531 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.2.38

• 8.3.0

• 8.4.0

Please check the Fix Version/s of ARSN-531, or the target
branch of this pull request.

[dvasilas]

Suggested change

	request.headers['content-length']; // here
	request.headers['content-length'];

[leif-scality]

removed

[dvasilas]

I think this is not in the correct place.
It is inside the eachSeries for location, so if there are multiple locations, it will be called multiple times.

It may be better to place it inside:

if (!response.headersSent) {
    response.writeHead(httpCodeOnSucess);
}
`

[dvasilas]

Also (more important), shouldn't this include bytesSent? It is used by objectGet.

[leif-scality]

fixed, calculated the bytesSent using _computeContentLengthFromLocation

[dvasilas]

retrieveDataAzure is out of context, but you could add a TODO comment saying that it does not capture log access log fields in case this feature is ever used in Artesca.

[leif-scality]

added the comment