LOGC-7: Implement log processor #13
Open
+2,225
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no offset exists, max() returns NULL which ClickHouse driver converts to Unix epoch (1970-01-01). Use maxOrNull() and sql.NullTime to properly detect NULL values. Return Go zero time for missing offsets, enabling reliable IsZero() checks. This makes the case in which a bucket does not have a committed offset yet more explicit.
Add OffsetManagerInterface and UploaderInterface to enable tests to use custom implementations (for injecting errors). Existing implementations already satisfy these interfaces.
- S3TestHelper for bucket/object operations - CountingUploader for tracking upload attempts - InsertTestLogWithTargetBucket for inserting test data - FailingOffsetManager for simulating offset commit failures
- Discovery cycle with configurable interval - Parallel batch processing with worker pool - Retry logic - Error classification (permanent vs transient)
Transform stub main into complete application - Load and validate configuration - Set up logging - Create and initialize processor - Signal handling - Shutdown timeout with cleanup
dvasilas
force-pushed
the
improvement/LOGC-7
branch
from
819196a to
ca263f9
Compare
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (77.22%) is below the adjusted base coverage (85.02%). You can increase the head coverage or adjust the Removed Code Behavior. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## main #13 +/- ##
==========================================
- Coverage 85.43% 77.22% -8.22%
==========================================
Files 12 15 +3
Lines 515 1036 +521
==========================================
+ Hits 440 800 +360
- Misses 52 195 +143
- Partials 23 41 +18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the core log processing logic.
Best reviewed commit by commit.