Add UUID provided function#253
Conversation
Yes, please. I think that would be very valuable. It would at least prove that the code produces something that is syntactically correct. You could also generate two UUIDs and verify that they are different from each other. |
|
Overall this looks good. My comments are just nitpicks, really. Great work! 👍 |
|
I think this looks good now. At least I don't know of any actual problems preventing a merge. Could you rebase it on master so I can verify that everything is OK and merge it without including the other PR? |
5987af0 to
138f217
Compare
138f217 to
a6652d6
Compare
done...now it's just the added new function...looking forward to see the new version on maven central :-) |
larsga
left a comment
There was a problem hiding this comment.
This all looks great now. Thank you very much for doing this, and for adapting the design so quickly based on feedback. Several times you changed your proposal exactly the way I was thinking you should before I had time to suggest it. 👍
added uuid build-in function