MNT Rework workflows: split concerns (alternative) - #18
Open
jeremiedbb wants to merge 9 commits into
Open
jeremiedbb wants to merge 9 commits into
jeremiedbb wants to merge 9 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative version of #16
Closes #13
Closes #14
Closes #15
Toward #6
This PR proposes to rework the workflows to separate the concerns and required permissions. It makes the release workflow closer to what we've been doing so far. It also allows to safely test the wheels from scikit-learn without keeping 2 wheel config in sync.
The release steps would look as follow:
(using [cd build] just calls the
build-wheelsworkflow from this repo, but it can't publish or anything, so it's safe)(this way the author of the release PR can iterate and test the wheels, whereas right now we need a maintainer of the release repo to test the wheels against that PR)
publishworkflow for the maintenance branch.(this workflows calls build-wheels and then publishes to testpypi and pypi in a row)
Remark: similar structure as the other PR. The difference is that the publish workflow directly calls build-wheels and uses the artifacts within the job, so no need to loop through previous build workflows.
The nightly builds become:
nightlyworkflow. It uses thebuild-wheelsworkflow, then uploads to anaconda.(essentially the same as before)
(commented for now since it requires some setup in sklearn)
Side notes:
Follow-up:
publish.ymlinstead ofwheels.yml.