-
Notifications
You must be signed in to change notification settings - Fork 1
✨ New job screen #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
✨ New job screen #77
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
beefcaf
refactor: replace MUI Typography with HTML headings and improve job d…
peppermint-juli d30e5d1
Update components/ui/web/components/content/jobs/detail/jobFullDetail…
peppermint-juli c70d7fa
Merge commit '5e0579ef35bbeb73a11c4506546bc7bc2644b33b'
peppermint-juli 50ff8e3
feat: Reuse newSession component to create new Jobs
peppermint-juli 3e23cea
Reuse NewSession form to create
peppermint-juli 44ebc94
feat: update getDomains query to accept jobs parameter
peppermint-juli 15d191c
* Added Command step and steppers component to NewJob component
peppermint-juli dbd479c
feat: add working directory selection and default job parameters to N…
peppermint-juli b2c518c
Connected NewJob endpoint to component. Code Cleanup and created a ne…
peppermint-juli 3788839
feat: add optional name field to CreateJobParams and Job types
peppermint-juli 8d34972
refactor: replace MUI Typography with HTML headings and improve job d…
peppermint-juli 7ceebef
Update components/ui/web/components/content/jobs/detail/jobFullDetail…
peppermint-juli e91fdff
Merge branch 'main' into new-job-screen
peppermint-juli 196998b
Apply suggestions from code review
peppermint-juli 7e57d3d
Update components/ui/web/components/content/jobs/new/commandForm.tsx
peppermint-juli 85ada47
fix: update comparison operator for domain choice and add key prop to…
peppermint-juli f61b519
* Make helpdesk email link an env variable
peppermint-juli e9c078a
feat: add helpdesk email as an environment variable in web deployment
peppermint-juli 9cfaecf
Merge branch 'main' into new-job-screen
peppermint-juli 849e509
feat: refactor session management to use NewComputeSession component …
peppermint-juli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| NEXT_PUBLIC_FILE_SERVICE_URL=https://apps.sciserver.org/fileservice/api/ | ||
| NEXT_PUBLIC_LOGIN_PORTAL_URL=https://apps.sciserver.org/login-portal/ | ||
| NEXT_PUBLIC_GRAPHQL_URL=http://localhost:4000/graphql | ||
| # NEXT_PUBLIC_GRAPHQL_URL=https://apps.sciserver.org/graphql | ||
| # NEXT_PUBLIC_GRAPHQL_URL=http://localhost:4000/graphql | ||
| NEXT_PUBLIC_GRAPHQL_URL=https://apps.sciserver.org/graphql | ||
| NEXT_PUBLIC_NOTEBOOKS_URL=https://apps.sciserver.org/compute/ | ||
| NEXT_PUBLIC_FILES_URL=https://apps.sciserver.org/dashboard/files/uservolumes | ||
| NEXT_PUBLIC_BASE_PATH='/web' | ||
|
|
@@ -11,4 +11,7 @@ NEXT_PUBLIC_COMPUTE_PING_INTERVAL=60000 #time in milliseconds | |
| NEXT_PUBLIC_LANDING_ROUTE=/datasets #default landing page to redirect from login | ||
| NEXT_PUBLIC_QUICK_START_CONFIG='dom=Interactive%20Docker%20Compute%20Domain&img=Sciserver%20Essentials%20(Test)&dvs=97' | ||
| NEXT_PUBLIC_NEW_SESSION_DOMAIN_NAME_DEFAULT=Interactive Docker Compute Domain | ||
| NEXT_PUBLIC_NEW_SESSION_IMAGE_NAME_DEFAULT=Sciserver Essentials (Test) | ||
| NEXT_PUBLIC_NEW_SESSION_IMAGE_NAME_DEFAULT=SciServer Essentials 4.0 | ||
| NEXT_PUBLIC_NEW_JOB_DOMAIN_NAME_DEFAULT=Small Jobs Domain | ||
| NEXT_PUBLIC_NEW_JOB_IMAGE_NAME_DEFAULT=SciServer Essentials 4.0 | ||
| [email protected] | ||
54 changes: 0 additions & 54 deletions
54
components/ui/web/components/content/compute/newSession/imageAccordion.tsx
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the commented line and then from here on not modify these lines for typical PRs. local workflows should have a way to replace this without committing the changes (either by another file or by restoring after testing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't usually modify it, but since I was going to make a change to this file, I decided to commit this one too. For local deployments, it's best to have this point to the apps.sciserver.org version of the GraphQL instead of the local version.